Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/extensions/app_notify_channel_setup.cc

Issue 10828021: Simplify ParseCWSChannelServiceResponse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/app_notify_channel_setup.h" 5 #include "chrome/browser/extensions/app_notify_channel_setup.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 return StringPrintf(kAuthorizationHeaderFormat, auth_token.c_str()); 400 return StringPrintf(kAuthorizationHeaderFormat, auth_token.c_str());
401 } 401 }
402 402
403 // static 403 // static
404 bool AppNotifyChannelSetup::ParseCWSChannelServiceResponse( 404 bool AppNotifyChannelSetup::ParseCWSChannelServiceResponse(
405 const std::string& data, std::string* result) { 405 const std::string& data, std::string* result) {
406 scoped_ptr<base::Value> value(base::JSONReader::Read(data)); 406 scoped_ptr<base::Value> value(base::JSONReader::Read(data));
407 if (!value.get() || value->GetType() != base::Value::TYPE_DICTIONARY) 407 if (!value.get() || value->GetType() != base::Value::TYPE_DICTIONARY)
408 return false; 408 return false;
409 409
410 Value* channel_id_value;
411 DictionaryValue* dict = static_cast<DictionaryValue*>(value.get()); 410 DictionaryValue* dict = static_cast<DictionaryValue*>(value.get());
412 if (!dict->Get("id", &channel_id_value)) 411 return dict->GetString("id", result);
413 return false;
414 if (channel_id_value->GetType() != base::Value::TYPE_STRING)
415 return false;
416
417 StringValue* channel_id = static_cast<StringValue*>(channel_id_value);
418 channel_id->GetAsString(result);
419 return true;
420 } 412 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698