Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Issue 10827457: rename refactor SystemLibraryManager -> PackagelibraryManager SdkLibraryManager -> SystemLibraryM... (Closed)

Created:
8 years, 4 months ago by keertip
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

rename refactor SystemLibraryManager -> PackagelibraryManager SdkLibraryManager -> SystemLibraryManager Committed: https://code.google.com/p/dart/source/detail?r=11101

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+831 lines, -1201 lines) Patch
M compiler/java/com/google/dart/compiler/CommandLineOptions.java View 1 chunk +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/CompilerConfiguration.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/DartCompiler.java View 7 chunks +7 lines, -7 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java View 4 chunks +4 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DefaultDartArtifactProvider.java View 2 chunks +2 lines, -2 lines 1 comment Download
M compiler/java/com/google/dart/compiler/DelegatingCompilerConfiguration.java View 1 chunk +1 line, -1 line 1 comment Download
A compiler/java/com/google/dart/compiler/PackageLibraryManager.java View 1 chunk +321 lines, -0 lines 0 comments Download
D compiler/java/com/google/dart/compiler/SdkLibraryManager.java View 1 chunk +0 lines, -273 lines 0 comments Download
M compiler/java/com/google/dart/compiler/SystemLibraryManager.java View 2 chunks +192 lines, -240 lines 0 comments Download
M compiler/java/com/google/dart/compiler/UrlDartSource.java View 1 chunk +1 line, -1 line 1 comment Download
M compiler/java/com/google/dart/compiler/UrlLibrarySource.java View 3 chunks +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/UrlSource.java View 2 chunks +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/testing/TestCompilerConfiguration.java View 3 chunks +4 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/CompilerTests.java View 1 chunk +1 line, -1 line 1 comment Download
A compiler/javatests/com/google/dart/compiler/PackageLibraryManagerTest.java View 1 chunk +118 lines, -0 lines 1 comment Download
D compiler/javatests/com/google/dart/compiler/SystemLibraryManagerTest.java View 1 chunk +0 lines, -118 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.eclipse.ui/src/com/google/dart/eclipse/ui/internal/navigator/DartNavigatorContentProvider.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java View 4 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Context.java View 4 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/EditContext.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/SavedContext.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisIndexManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartBuilder.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ErrorRecordingContext.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/impl/InMemoryIndex.java View 5 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java View 7 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartProjectImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProvider.java View 5 chunks +8 lines, -8 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProvider.java View 1 chunk +0 lines, -111 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/delta/DeltaProcessor.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java View 3 chunks +4 lines, -4 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/jobs/CleanLibrariesJob.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/bindings/BindingUtils.java View 3 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java View 8 chunks +10 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java View 4 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/net/URIUtilities.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/workingcopy/WorkingCopyOwner.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerAdapter.java View 2 chunks +4 lines, -4 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java View 4 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisTestUtilities.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ContextTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/completion/CompletionEngineTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderAnyTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderDartCTest.java View 2 chunks +4 lines, -4 lines 1 comment Download
A + editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderTest.java View 7 chunks +8 lines, -8 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderAnyTest.java View 1 chunk +0 lines, -67 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderDartCTest.java View 1 chunk +0 lines, -40 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java View 1 chunk +0 lines, -152 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/TestAll.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/test/util/TestProject.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/chromejs/DartSourcePathComputerDelegate.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java View 2 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerRemoteScriptSourceContainer.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/view/DebuggerPatternMatchListener.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/deploy/ApplicationWorkbenchAdvisor.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/src/com/google/dart/tools/ui/swtbot/conditions/AnalysisCompleteCondition.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/DartUIStartup.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/IgnoreResourceAction.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/SdkDirectoryNode.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/IgnoreResourceHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/handlers/UnIgnoreResourceHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartBasePreferencePage.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitDocumentProvider.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitEditor.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
keertip
8 years, 4 months ago (2012-08-21 21:19:39 UTC) #1
danrubel
LGTM. Spot checked. https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/javatests/com/google/dart/compiler/PackageLibraryManagerTest.java File compiler/javatests/com/google/dart/compiler/PackageLibraryManagerTest.java (right): https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/javatests/com/google/dart/compiler/PackageLibraryManagerTest.java#newcode24 compiler/javatests/com/google/dart/compiler/PackageLibraryManagerTest.java:24: PackageLibraryManager systemLibraryManager = new PackageLibraryManager(); would ...
8 years, 4 months ago (2012-08-21 21:26:39 UTC) #2
Brian Wilkerson
8 years, 4 months ago (2012-08-21 21:30:01 UTC) #3
LGTM

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DefaultDartArtifactProvider.java
(right):

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DefaultDartArtifactProvider.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DelegatingCompilerConfiguration.java
(right):

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DelegatingCompilerConfiguration.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/UrlDartSource.java (right):

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/UrlDartSource.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/CompilerTests.java (right):

https://chromiumcodereview.appspot.com/10827457/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/CompilerTests.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10827457/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java
(right):

https://chromiumcodereview.appspot.com/10827457/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java:2:
* Copyright (c) 2011, the Dart project authors.
nit: copyright year

https://chromiumcodereview.appspot.com/10827457/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerAdapter.java
(right):

https://chromiumcodereview.appspot.com/10827457/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerAdapter.java:1:
package com.google.dart.tools.core.analysis;
No copyright notice.

https://chromiumcodereview.appspot.com/10827457/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderDartCTest.java
(right):

https://chromiumcodereview.appspot.com/10827457/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderDartCTest.java:2:
* Copyright 2011 Dart project authors.
nit: copyright year

Powered by Google App Engine
This is Rietveld 408576698