Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10827449: mac/rlz: Correctly check for fd existence (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

mac/rlz: Correctly check for fd existence Found while looking at this file for http://crbug.com/143950, but I don't think this causes that bug. BUG=143950 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M rlz/mac/lib/rlz_value_store_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
This would only be an issue if the lock gets fd 0 (since closing fd ...
8 years, 4 months ago (2012-08-21 18:25:36 UTC) #1
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-21 18:27:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10827449/1
8 years, 4 months ago (2012-08-21 18:36:53 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 19:57:53 UTC) #4
Try job failure for 10827449-1 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698