rlz/mac/lib/rlz_value_store_mac.mm - Issue 10827449: mac/rlz: Correctly check for fd existence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rlz/mac/lib/rlz_value_store_mac.mm

Issue 10827449: mac/rlz: Correctly check for fd existence (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: rlz/mac/lib/rlz_value_store_mac.mm

diff --git a/rlz/mac/lib/rlz_value_store_mac.mm b/rlz/mac/lib/rlz_value_store_mac.mm

index 11a3c3d0f0a5caba87596bad5b08b00acbef3387..b1d082d12e4da259355b7aba13894cd12e986cf6 100644

--- a/rlz/mac/lib/rlz_value_store_mac.mm

+++ b/rlz/mac/lib/rlz_value_store_mac.mm

@@ -296,7 +296,7 @@ bool RecursiveCrossProcessLock::TryGetCrossProcessLock(

}

void RecursiveCrossProcessLock::ReleaseLock() {

- if (file_lock_) {

+ if (file_lock_ != -1) {

ignore_result(HANDLE_EINTR(flock(file_lock_, LOCK_UN)));

ignore_result(HANDLE_EINTR(close(file_lock_)));

file_lock_ = -1;

« no previous file with comments | « no previous file | no next file » | no next file with comments »