Issue 10827421: Removed benchmark results object from rendering benchmarks, now one result per benchmark

Issue 10827421: Removed benchmark results object from rendering benchmarks, now one result per benchmark (Closed)

Created:
8 years, 4 months ago by dmurph

Modified:
8 years, 4 months ago

Reviewers:
nduca, piman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, scheib

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Removed benchmark results object from rendering benchmarks, now one result per benchmark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152426

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -101 lines)			Patch
M	content/content_renderer.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/all_rendering_benchmarks.cc	View	5 chunks	+47 lines, -38 lines	2 comments	Download
M	content/renderer/gpu/gpu_benchmarking_extension.cc	View	4 chunks	+9 lines, -35 lines	0 comments	Download
M	content/renderer/rendering_benchmark.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
D	content/renderer/rendering_benchmark_results.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

piman

lgtm https://chromiumcodereview.appspot.com/10827421/diff/1/content/renderer/all_rendering_benchmarks.cc File content/renderer/all_rendering_benchmarks.cc (right): https://chromiumcodereview.appspot.com/10827421/diff/1/content/renderer/all_rendering_benchmarks.cc#newcode59 content/renderer/all_rendering_benchmarks.cc:59: return paint_time_total_.InMillisecondsF(); did you intend to switch from ...

8 years, 4 months ago (2012-08-20 17:58:56 UTC) #3

dmurph

https://chromiumcodereview.appspot.com/10827421/diff/1/content/renderer/all_rendering_benchmarks.cc File content/renderer/all_rendering_benchmarks.cc (right): https://chromiumcodereview.appspot.com/10827421/diff/1/content/renderer/all_rendering_benchmarks.cc#newcode59 content/renderer/all_rendering_benchmarks.cc:59: return paint_time_total_.InMillisecondsF(); On 2012/08/20 17:58:56, piman wrote: > did ...

8 years, 4 months ago (2012-08-20 19:30:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmurph@chromium.org/10827421/1

8 years, 4 months ago (2012-08-20 19:30:25 UTC) #6

Change committed as 152426

Expand Messages | Collapse Messages