content/renderer/rendering_benchmark.h - Issue 10827421: Removed benchmark results object from rendering benchmarks, now one result per benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/rendering_benchmark.h

Issue 10827421: Removed benchmark results object from rendering benchmarks, now one result per benchmark (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/all_rendering_benchmarks.cc ('K') | « content/renderer/gpu/gpu_benchmarking_extension.cc ('k') | content/renderer/rendering_benchmark_results.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/rendering_benchmark.h

diff --git a/content/renderer/rendering_benchmark.h b/content/renderer/rendering_benchmark.h

index c99236d2c1dc0c19bf257d9a2e878e63b1cd8fa2..44b5a84d79acab6a3789cc14edf2a49d7a18bf0b 100644

--- a/content/renderer/rendering_benchmark.h

+++ b/content/renderer/rendering_benchmark.h

@@ -23,8 +23,7 @@ class RenderingBenchmark {

virtual void SetUp(WebKit::WebViewBenchmarkSupport* benchmarkSupport) {}

- virtual void Run(RenderingBenchmarkResults* results,

- WebKit::WebViewBenchmarkSupport* benchmarkSupport) = 0;

+ virtual double Run(WebKit::WebViewBenchmarkSupport* benchmarkSupport) = 0;

virtual void TearDown(WebKit::WebViewBenchmarkSupport* benchmarkSupport) {}