Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10827420: Revert 152221 - chromeos: Sync animation. (Closed)

Created:
8 years, 4 months ago by flackr
Modified:
8 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 152221 - chromeos: Sync animation. This was causing Linux ChromiumOS (dbg) browser_tests to fail with timeouts on several tests, identified with a local bisect. - Pulse app list button while LauncherModel has STATUS_LOADING; - Remove LauncherItemStatus::STATUS_IS_PENDING etc since it is no longer needed; - ChromeLauncherController sets LauncherModel::STATUS_LOADING on starting and watch for sync finish and pending extension install. It sets LauncherModel::STATUS_NORMAL when sync is finished and there is no pending extension install from sync, or when a maximum 60 seconds timeout since turning on loading status; BUG=129236 TEST=Verify sync animation after OOBE. Review URL: https://chromiumcodereview.appspot.com/10829268 TBR=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -279 lines) Patch
M ash/ash_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/launcher/app_list_button.h View 2 chunks +1 line, -4 lines 0 comments Download
M ash/launcher/app_list_button.cc View 1 chunk +10 lines, -88 lines 0 comments Download
M ash/launcher/launcher_button.h View 4 chunks +11 lines, -1 line 0 comments Download
M ash/launcher/launcher_button.cc View 6 chunks +106 lines, -1 line 0 comments Download
M ash/launcher/launcher_model.h View 3 chunks +0 lines, -10 lines 0 comments Download
M ash/launcher/launcher_model.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M ash/launcher/launcher_model_observer.h View 1 chunk +1 line, -4 lines 0 comments Download
M ash/launcher/launcher_model_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/launcher/launcher_types.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/launcher/launcher_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/launcher/launcher_view.cc View 7 chunks +36 lines, -17 lines 0 comments Download
MM ash/launcher/launcher_view_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 8 chunks +8 lines, -22 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 11 chunks +48 lines, -81 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +18 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
flackr
8 years, 4 months ago (2012-08-20 17:33:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698