Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: webkit/blob/blob_data.cc

Issue 10827414: Factor out common Element struct from BlobData and ResourceRequestBody (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: webkit/common -> webkit/base Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/blob/blob_data.h ('k') | webkit/blob/blob_storage_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/blob/blob_data.cc
diff --git a/webkit/blob/blob_data.cc b/webkit/blob/blob_data.cc
index 894736754a37796495c4e1aac874c04195492aa2..e000ee27b674b6f1d0c946abfedd650166409ca3 100644
--- a/webkit/blob/blob_data.cc
+++ b/webkit/blob/blob_data.cc
@@ -11,15 +11,6 @@
namespace webkit_blob {
-BlobData::Item::Item()
- : type(TYPE_DATA),
- data_external(NULL),
- offset(0),
- length(0) {
-}
-
-BlobData::Item::~Item() {}
-
BlobData::BlobData() {}
BlobData::~BlobData() {}
@@ -27,30 +18,30 @@ BlobData::~BlobData() {}
void BlobData::AppendData(const char* data, size_t length) {
DCHECK(length > 0);
items_.push_back(Item());
- items_.back().SetToData(data, length);
+ items_.back().SetToBytes(data, length);
}
-void BlobData::AppendFile(const FilePath& file_path, uint64 offset,
- uint64 length,
+void BlobData::AppendFile(const FilePath& file_path,
+ uint64 offset, uint64 length,
const base::Time& expected_modification_time) {
DCHECK(length > 0);
items_.push_back(Item());
- items_.back().SetToFile(file_path, offset, length,
- expected_modification_time);
+ items_.back().SetToFilePathRange(file_path, offset, length,
+ expected_modification_time);
}
void BlobData::AppendBlob(const GURL& blob_url, uint64 offset, uint64 length) {
DCHECK(length > 0);
items_.push_back(Item());
- items_.back().SetToBlob(blob_url, offset, length);
+ items_.back().SetToBlobUrlRange(blob_url, offset, length);
}
int64 BlobData::GetMemoryUsage() const {
int64 memory = 0;
for (std::vector<Item>::const_iterator iter = items_.begin();
iter != items_.end(); ++iter) {
- if (iter->type == TYPE_DATA)
- memory += iter->data.size();
+ if (iter->type() == Item::TYPE_BYTES)
+ memory += iter->length();
}
return memory;
}
« no previous file with comments | « webkit/blob/blob_data.h ('k') | webkit/blob/blob_storage_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698