Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 10827414: Factor out common Element struct from BlobData and ResourceRequestBody (Closed)

Created:
8 years, 4 months ago by kinuko
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, pam+watch_chromium.org, kinuko+watch, willchan no longer on Chromium, hashimoto
Visibility:
Public.

Description

Factor out common Element struct from BlobData and ResourceRequestBody BUG=110119 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152987

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : build fix #

Patch Set 4 : rebased #

Patch Set 5 : webkit/common -> webkit/base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -406 lines) Patch
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/fileapi/webblob_messages.h View 1 chunk +0 lines, -13 lines 0 comments Download
M content/common/fileapi/webblobregistry_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/common_param_traits.h View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits.cc View 1 2 3 4 2 chunks +65 lines, -64 lines 0 comments Download
A webkit/base/data_element.h View 1 2 3 4 1 chunk +116 lines, -0 lines 0 comments Download
A webkit/base/data_element.cc View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A webkit/base/webkit_base.gypi View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
A webkit/base/webkit_base_export.h View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
M webkit/blob/blob_data.h View 1 2 3 4 3 chunks +2 lines, -85 lines 0 comments Download
M webkit/blob/blob_data.cc View 1 2 chunks +8 lines, -17 lines 0 comments Download
M webkit/blob/blob_storage_controller.cc View 1 2 3 2 chunks +27 lines, -28 lines 0 comments Download
M webkit/blob/blob_url_request_job.cc View 1 7 chunks +17 lines, -17 lines 0 comments Download
M webkit/blob/view_blob_internals_job.cc View 1 1 chunk +15 lines, -17 lines 0 comments Download
M webkit/blob/webkit_blob.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/resource_request_body.h View 1 2 3 4 4 chunks +4 lines, -117 lines 0 comments Download
M webkit/glue/resource_request_body.cc View 1 2 3 3 chunks +21 lines, -29 lines 0 comments Download
M webkit/glue/resource_request_body_unittest.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/webkit_support.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kinuko
Add webkit_common::DataElement to replace/merge BlobData::Item and ResourceRequestBody::Element. The change itself is straightforward, except that it's ...
8 years, 4 months ago (2012-08-21 14:30:01 UTC) #1
jam
chrome&content lgtm
8 years, 4 months ago (2012-08-21 16:04:01 UTC) #2
willchan no longer on Chromium
Is this an FYI for me or is there anything in particular I should look ...
8 years, 4 months ago (2012-08-21 18:13:56 UTC) #3
michaeln
LGTM++
8 years, 4 months ago (2012-08-21 19:29:37 UTC) #4
tony
I defer to darin the introduction of webkit/common. It's a bit weird since webkit/common doesn't ...
8 years, 4 months ago (2012-08-21 20:48:20 UTC) #5
kinuko
willchan: it's just FYI, I wanted to let you know I'm deprecating more code originally ...
8 years, 4 months ago (2012-08-22 03:44:41 UTC) #6
michaeln1
On 2012/08/22 03:44:41, kinuko wrote: > willchan: it's just FYI, I wanted to let you ...
8 years, 4 months ago (2012-08-22 19:01:42 UTC) #7
tony
On 2012/08/22 19:01:42, michaeln1 wrote: > On 2012/08/22 03:44:41, kinuko wrote: > > willchan: it's ...
8 years, 4 months ago (2012-08-22 20:52:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10827414/18001
8 years, 4 months ago (2012-08-23 09:07:57 UTC) #9
commit-bot: I haz the power
Change committed as 152987
8 years, 4 months ago (2012-08-23 14:32:45 UTC) #10
darin (slow to review)
8 years, 3 months ago (2012-08-27 18:16:57 UTC) #11
LGTM2  ... I had been planning on creating webkit/base for other (similar)
reasons.
-Darin

On Thu, Aug 23, 2012 at 7:32 AM, <commit-bot@chromium.org> wrote:

> Change committed as 152987
>
>
https://chromiumcodereview.**appspot.com/10827414/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698