Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 10827406: contacts: Rename provider_id to contact_id. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

contacts: Rename provider_id to contact_id. As suggested by satorux@, this change renames the ID field in contacts::Contact to make it clearer that it's a contact-specific (albeit provider-assigned) ID rather than one corresponding to the provider itself. BUG=128805 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152285

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -88 lines) Patch
M chrome/browser/chromeos/contacts/contact.proto View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/contacts/contact_database.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_database_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_manager.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_manager_unittest.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_store.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_test_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/contacts/fake_contact_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/contacts/fake_contact_store.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/contacts/fake_contact_store.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/contacts/google_contact_store.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/contacts/google_contact_store.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/contacts/google_contact_store_unittest.cc View 8 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-08-17 22:39:05 UTC) #1
satorux1
LGTM
8 years, 4 months ago (2012-08-17 22:41:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10827406/5001
8 years, 4 months ago (2012-08-19 14:04:40 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-19 16:56:46 UTC) #4
Change committed as 152285

Powered by Google App Engine
This is Rietveld 408576698