Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/chromeos/contacts/contact_database_unittest.cc

Issue 10827406: contacts: Rename provider_id to contact_id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/contacts/contact_database.h" 5 #include "chrome/browser/chromeos/contacts/contact_database.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 // OnContactsLoaded() to LoadContacts(). 138 // OnContactsLoaded() to LoadContacts().
139 scoped_ptr<ScopedVector<Contact> > loaded_contacts_; 139 scoped_ptr<ScopedVector<Contact> > loaded_contacts_;
140 scoped_ptr<UpdateMetadata> loaded_metadata_; 140 scoped_ptr<UpdateMetadata> loaded_metadata_;
141 141
142 DISALLOW_COPY_AND_ASSIGN(ContactDatabaseTest); 142 DISALLOW_COPY_AND_ASSIGN(ContactDatabaseTest);
143 }; 143 };
144 144
145 TEST_F(ContactDatabaseTest, SaveAndReload) { 145 TEST_F(ContactDatabaseTest, SaveAndReload) {
146 // Save a contact to the database and check that we get the same data back 146 // Save a contact to the database and check that we get the same data back
147 // when loading it. 147 // when loading it.
148 const std::string kProviderId = "provider_id_1"; 148 const std::string kContactId = "contact_id_1";
149 scoped_ptr<Contact> contact(new Contact); 149 scoped_ptr<Contact> contact(new Contact);
150 InitContact(kProviderId, "1", false, contact.get()); 150 InitContact(kContactId, "1", false, contact.get());
151 AddEmailAddress("email_1", Contact_AddressType_Relation_HOME, 151 AddEmailAddress("email_1", Contact_AddressType_Relation_HOME,
152 "email_label_1", true, contact.get()); 152 "email_label_1", true, contact.get());
153 AddEmailAddress("email_2", Contact_AddressType_Relation_WORK, 153 AddEmailAddress("email_2", Contact_AddressType_Relation_WORK,
154 "", false, contact.get()); 154 "", false, contact.get());
155 AddPhoneNumber("123-456-7890", Contact_AddressType_Relation_HOME, 155 AddPhoneNumber("123-456-7890", Contact_AddressType_Relation_HOME,
156 "phone_label", true, contact.get()); 156 "phone_label", true, contact.get());
157 AddPostalAddress("postal_1", Contact_AddressType_Relation_HOME, 157 AddPostalAddress("postal_1", Contact_AddressType_Relation_HOME,
158 "postal_label_1", true, contact.get()); 158 "postal_label_1", true, contact.get());
159 AddPostalAddress("postal_2", Contact_AddressType_Relation_OTHER, 159 AddPostalAddress("postal_2", Contact_AddressType_Relation_OTHER,
160 "postal_label_2", false, contact.get()); 160 "postal_label_2", false, contact.get());
(...skipping 12 matching lines...) Expand all
173 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true); 173 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true);
174 scoped_ptr<ScopedVector<Contact> > loaded_contacts; 174 scoped_ptr<ScopedVector<Contact> > loaded_contacts;
175 scoped_ptr<UpdateMetadata> loaded_metadata; 175 scoped_ptr<UpdateMetadata> loaded_metadata;
176 LoadContacts(&loaded_contacts, &loaded_metadata); 176 LoadContacts(&loaded_contacts, &loaded_metadata);
177 EXPECT_EQ(VarContactsToString(1, contact.get()), 177 EXPECT_EQ(VarContactsToString(1, contact.get()),
178 ContactsToString(*loaded_contacts)); 178 ContactsToString(*loaded_contacts));
179 EXPECT_EQ(kLastUpdateTime, loaded_metadata->last_update_start_time()); 179 EXPECT_EQ(kLastUpdateTime, loaded_metadata->last_update_start_time());
180 180
181 // Modify the contact, save it, and check that the loaded contact is also 181 // Modify the contact, save it, and check that the loaded contact is also
182 // updated. 182 // updated.
183 InitContact(kProviderId, "2", false, contact.get()); 183 InitContact(kContactId, "2", false, contact.get());
184 AddEmailAddress("email_3", Contact_AddressType_Relation_OTHER, 184 AddEmailAddress("email_3", Contact_AddressType_Relation_OTHER,
185 "email_label_2", true, contact.get()); 185 "email_label_2", true, contact.get());
186 AddPhoneNumber("phone_2", Contact_AddressType_Relation_OTHER, 186 AddPhoneNumber("phone_2", Contact_AddressType_Relation_OTHER,
187 "phone_label_2", false, contact.get()); 187 "phone_label_2", false, contact.get());
188 AddPostalAddress("postal_3", Contact_AddressType_Relation_HOME, 188 AddPostalAddress("postal_3", Contact_AddressType_Relation_HOME,
189 "postal_label_3", true, contact.get()); 189 "postal_label_3", true, contact.get());
190 SetPhoto(gfx::Size(64, 64), contact.get()); 190 SetPhoto(gfx::Size(64, 64), contact.get());
191 contacts_to_save.reset(new ContactPointers); 191 contacts_to_save.reset(new ContactPointers);
192 contacts_to_save->push_back(contact.get()); 192 contacts_to_save->push_back(contact.get());
193 metadata_to_save.reset(new UpdateMetadata); 193 metadata_to_save.reset(new UpdateMetadata);
194 const int64 kNewLastUpdateTime = 5678; 194 const int64 kNewLastUpdateTime = 5678;
195 metadata_to_save->set_last_update_start_time(kNewLastUpdateTime); 195 metadata_to_save->set_last_update_start_time(kNewLastUpdateTime);
196 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true); 196 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true);
197 197
198 LoadContacts(&loaded_contacts, &loaded_metadata); 198 LoadContacts(&loaded_contacts, &loaded_metadata);
199 EXPECT_EQ(VarContactsToString(1, contact.get()), 199 EXPECT_EQ(VarContactsToString(1, contact.get()),
200 ContactsToString(*loaded_contacts)); 200 ContactsToString(*loaded_contacts));
201 EXPECT_EQ(kNewLastUpdateTime, loaded_metadata->last_update_start_time()); 201 EXPECT_EQ(kNewLastUpdateTime, loaded_metadata->last_update_start_time());
202 } 202 }
203 203
204 TEST_F(ContactDatabaseTest, FullAndPartialUpdates) { 204 TEST_F(ContactDatabaseTest, FullAndPartialUpdates) {
205 // Do a full update that inserts two contacts into the database. 205 // Do a full update that inserts two contacts into the database.
206 const std::string kProviderId1 = "provider_id_1"; 206 const std::string kContactId1 = "contact_id_1";
207 const std::string kSharedEmail = "foo@example.org"; 207 const std::string kSharedEmail = "foo@example.org";
208 scoped_ptr<Contact> contact1(new Contact); 208 scoped_ptr<Contact> contact1(new Contact);
209 InitContact(kProviderId1, "1", false, contact1.get()); 209 InitContact(kContactId1, "1", false, contact1.get());
210 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_HOME, 210 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_HOME,
211 "", true, contact1.get()); 211 "", true, contact1.get());
212 212
213 const std::string kProviderId2 = "provider_id_2"; 213 const std::string kContactId2 = "contact_id_2";
214 scoped_ptr<Contact> contact2(new Contact); 214 scoped_ptr<Contact> contact2(new Contact);
215 InitContact(kProviderId2, "2", false, contact2.get()); 215 InitContact(kContactId2, "2", false, contact2.get());
216 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_WORK, 216 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_WORK,
217 "", true, contact2.get()); 217 "", true, contact2.get());
218 218
219 scoped_ptr<ContactPointers> contacts_to_save(new ContactPointers); 219 scoped_ptr<ContactPointers> contacts_to_save(new ContactPointers);
220 contacts_to_save->push_back(contact1.get()); 220 contacts_to_save->push_back(contact1.get());
221 contacts_to_save->push_back(contact2.get()); 221 contacts_to_save->push_back(contact2.get());
222 scoped_ptr<UpdateMetadata> metadata_to_save(new UpdateMetadata); 222 scoped_ptr<UpdateMetadata> metadata_to_save(new UpdateMetadata);
223 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true); 223 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true);
224 224
225 scoped_ptr<ScopedVector<Contact> > loaded_contacts; 225 scoped_ptr<ScopedVector<Contact> > loaded_contacts;
226 scoped_ptr<UpdateMetadata> loaded_metadata; 226 scoped_ptr<UpdateMetadata> loaded_metadata;
227 LoadContacts(&loaded_contacts, &loaded_metadata); 227 LoadContacts(&loaded_contacts, &loaded_metadata);
228 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()), 228 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()),
229 ContactsToString(*loaded_contacts)); 229 ContactsToString(*loaded_contacts));
230 230
231 // Do a partial update including just the second contact. 231 // Do a partial update including just the second contact.
232 InitContact(kProviderId2, "2b", false, contact2.get()); 232 InitContact(kContactId2, "2b", false, contact2.get());
233 AddPostalAddress("postal_1", Contact_AddressType_Relation_HOME, 233 AddPostalAddress("postal_1", Contact_AddressType_Relation_HOME,
234 "", true, contact2.get()); 234 "", true, contact2.get());
235 contacts_to_save.reset(new ContactPointers); 235 contacts_to_save.reset(new ContactPointers);
236 contacts_to_save->push_back(contact2.get()); 236 contacts_to_save->push_back(contact2.get());
237 metadata_to_save.reset(new UpdateMetadata); 237 metadata_to_save.reset(new UpdateMetadata);
238 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false); 238 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false);
239 LoadContacts(&loaded_contacts, &loaded_metadata); 239 LoadContacts(&loaded_contacts, &loaded_metadata);
240 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()), 240 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()),
241 ContactsToString(*loaded_contacts)); 241 ContactsToString(*loaded_contacts));
242 242
243 // Do an empty partial update and check that the metadata is still updated. 243 // Do an empty partial update and check that the metadata is still updated.
244 contacts_to_save.reset(new ContactPointers); 244 contacts_to_save.reset(new ContactPointers);
245 metadata_to_save.reset(new UpdateMetadata); 245 metadata_to_save.reset(new UpdateMetadata);
246 const int64 kLastUpdateTime = 1234; 246 const int64 kLastUpdateTime = 1234;
247 metadata_to_save->set_last_update_start_time(kLastUpdateTime); 247 metadata_to_save->set_last_update_start_time(kLastUpdateTime);
248 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false); 248 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false);
249 LoadContacts(&loaded_contacts, &loaded_metadata); 249 LoadContacts(&loaded_contacts, &loaded_metadata);
250 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()), 250 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()),
251 ContactsToString(*loaded_contacts)); 251 ContactsToString(*loaded_contacts));
252 EXPECT_EQ(kLastUpdateTime, loaded_metadata->last_update_start_time()); 252 EXPECT_EQ(kLastUpdateTime, loaded_metadata->last_update_start_time());
253 253
254 // Do a full update including just the first contact. The second contact 254 // Do a full update including just the first contact. The second contact
255 // should be removed from the database. 255 // should be removed from the database.
256 InitContact(kProviderId1, "1b", false, contact1.get()); 256 InitContact(kContactId1, "1b", false, contact1.get());
257 AddPostalAddress("postal_2", Contact_AddressType_Relation_WORK, 257 AddPostalAddress("postal_2", Contact_AddressType_Relation_WORK,
258 "", true, contact1.get()); 258 "", true, contact1.get());
259 AddPhoneNumber("phone", Contact_AddressType_Relation_HOME, 259 AddPhoneNumber("phone", Contact_AddressType_Relation_HOME,
260 "", true, contact1.get()); 260 "", true, contact1.get());
261 contacts_to_save.reset(new ContactPointers); 261 contacts_to_save.reset(new ContactPointers);
262 contacts_to_save->push_back(contact1.get()); 262 contacts_to_save->push_back(contact1.get());
263 metadata_to_save.reset(new UpdateMetadata); 263 metadata_to_save.reset(new UpdateMetadata);
264 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true); 264 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true);
265 LoadContacts(&loaded_contacts, &loaded_metadata); 265 LoadContacts(&loaded_contacts, &loaded_metadata);
266 EXPECT_EQ(VarContactsToString(1, contact1.get()), 266 EXPECT_EQ(VarContactsToString(1, contact1.get()),
(...skipping 29 matching lines...) Expand all
296 296
297 scoped_ptr<ScopedVector<Contact> > loaded_contacts; 297 scoped_ptr<ScopedVector<Contact> > loaded_contacts;
298 scoped_ptr<UpdateMetadata> loaded_metadata; 298 scoped_ptr<UpdateMetadata> loaded_metadata;
299 LoadContacts(&loaded_contacts, &loaded_metadata); 299 LoadContacts(&loaded_contacts, &loaded_metadata);
300 EXPECT_EQ(VarContactsToString(1, contact.get()), 300 EXPECT_EQ(VarContactsToString(1, contact.get()),
301 ContactsToString(*loaded_contacts)); 301 ContactsToString(*loaded_contacts));
302 } 302 }
303 303
304 } // namespace test 304 } // namespace test
305 } // namespace contacts 305 } // namespace contacts
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/contacts/contact_database.cc ('k') | chrome/browser/chromeos/contacts/contact_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698