Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 10827382: [Android] Remove the webview_core static library. (Closed)

Created:
8 years, 4 months ago by mkosiba (inactive)
Modified:
8 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Remove the webview_core static library. This removes webview_core and moves the deps directly into the libwebview target. The reason for this change is that make doesn't work correctly with a shared_library that doesn't contain any source files. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M android_webview/lib/android_webview.gyp View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mkosiba (inactive)
8 years, 4 months ago (2012-08-16 17:21:28 UTC) #1
Torne
LGTM; sorry for the problem :)
8 years, 4 months ago (2012-08-16 17:24:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/10827382/1
8 years, 4 months ago (2012-08-16 17:30:02 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 19:47:49 UTC) #4
Change committed as 151949

Powered by Google App Engine
This is Rietveld 408576698