Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Unified Diff: android_webview/lib/android_webview.gyp

Issue 10827382: [Android] Remove the webview_core static library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/lib/android_webview.gyp
diff --git a/android_webview/lib/android_webview.gyp b/android_webview/lib/android_webview.gyp
index ceeedceb2ce0139e25b12066f891f025f1813266..353e6bf0c6f43efca4087c5921a2ee185cd062d9 100644
--- a/android_webview/lib/android_webview.gyp
+++ b/android_webview/lib/android_webview.gyp
@@ -7,11 +7,8 @@
},
'targets': [
{
- # TODO(torne): This is vaguely based on the downstream android target
- # "chromeview_core" and once that target has been upstreamed we should
- # just depend on it instead.
- 'target_name': 'webview_core',
- 'type': 'static_library',
+ 'target_name': 'libwebview',
+ 'type': 'shared_library',
'dependencies': [
'../../chrome/chrome.gyp:browser',
'../../chrome/chrome.gyp:renderer',
@@ -20,16 +17,6 @@
'include_dirs': [
'../..',
],
- },
- {
- 'target_name': 'libwebview',
- 'type': 'shared_library',
- 'dependencies': [
- 'webview_core',
- ],
- 'include_dirs': [
- '../..',
- ],
'sources': [
'main/webview_entry_point.cc',
'main/webview_main_delegate.cc',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698