Issue 10827371: status tray: Use explicit conversion from ImageSkia to SkBitmap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827371: status tray: Use explicit conversion from ImageSkia to SkBitmap. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, Satish, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

status tray: Use explicit conversion from ImageSkia to SkBitmap. This status tray (or status icons) are not used on mac or chromeos. So for now it is sufficient to just convert from ImageSkia to SkBitmap using bitmap(). BUG=143104, 141146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151903

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -16 lines)			Patch
M	chrome/browser/background/background_mode_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_image.cc	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/media/media_stream_capture_indicator.cc	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/speech/speech_recognition_tray_icon_controller.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages