Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Side by Side Diff: chrome/browser/chromeos/login/user_image.cc

Issue 10827371: status tray: Use explicit conversion from ImageSkia to SkBitmap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/user_image.h" 5 #include "chrome/browser/chromeos/login/user_image.h"
6 6
7 #include "ui/gfx/codec/png_codec.h" 7 #include "ui/gfx/codec/png_codec.h"
8 8
9 namespace chromeos { 9 namespace chromeos {
10 10
11 namespace { 11 namespace {
12 12
13 bool IsAnimatedImage(const UserImage::RawImage& data) { 13 bool IsAnimatedImage(const UserImage::RawImage& data) {
14 const char kGIFStamp[] = "GIF"; 14 const char kGIFStamp[] = "GIF";
15 const size_t kGIFStampLength = sizeof(kGIFStamp) - 1; 15 const size_t kGIFStampLength = sizeof(kGIFStamp) - 1;
16 16
17 if (data.size() >= kGIFStampLength && 17 if (data.size() >= kGIFStampLength &&
18 memcmp(&data[0], kGIFStamp, kGIFStampLength) == 0) { 18 memcmp(&data[0], kGIFStamp, kGIFStampLength) == 0) {
19 return true; 19 return true;
20 } 20 }
21 return false; 21 return false;
22 } 22 }
23 23
24 bool EncodeBGRAImageSkia(const gfx::ImageSkia& image,
25 bool discard_transparency,
26 std::vector<unsigned char>* output) {
27 if (image.empty() || image.bitmap())
28 return false;
29 return gfx::PNGCodec::EncodeBGRASkBitmap(*image.bitmap(),
30 discard_transparency, output);
31 }
32
24 } // namespace 33 } // namespace
25 34
26 // static 35 // static
27 UserImage UserImage::CreateAndEncode(const gfx::ImageSkia& image) { 36 UserImage UserImage::CreateAndEncode(const gfx::ImageSkia& image) {
28 RawImage raw_image; 37 RawImage raw_image;
29 return gfx::PNGCodec::EncodeBGRASkBitmap(image, false, &raw_image) ? 38 return EncodeBGRAImageSkia(image, false, &raw_image) ?
30 UserImage(image, raw_image) : UserImage(image); 39 UserImage(image, raw_image) : UserImage(image);
31 } 40 }
32 41
33 UserImage::UserImage() 42 UserImage::UserImage()
34 : has_raw_image_(false), 43 : has_raw_image_(false),
35 has_animated_image_(false) { 44 has_animated_image_(false) {
36 } 45 }
37 46
38 UserImage::UserImage(const gfx::ImageSkia& image) 47 UserImage::UserImage(const gfx::ImageSkia& image)
39 : image_(image), 48 : image_(image),
40 has_raw_image_(false), 49 has_raw_image_(false),
41 has_animated_image_(false) { 50 has_animated_image_(false) {
42 } 51 }
43 52
44 UserImage::UserImage(const gfx::ImageSkia& image, 53 UserImage::UserImage(const gfx::ImageSkia& image,
45 const RawImage& raw_image) 54 const RawImage& raw_image)
46 : image_(image), 55 : image_(image),
47 has_raw_image_(false), 56 has_raw_image_(false),
48 has_animated_image_(false) { 57 has_animated_image_(false) {
49 if (IsAnimatedImage(raw_image)) { 58 if (IsAnimatedImage(raw_image)) {
50 has_animated_image_ = true; 59 has_animated_image_ = true;
51 animated_image_ = raw_image; 60 animated_image_ = raw_image;
52 if (gfx::PNGCodec::EncodeBGRASkBitmap(image_, false, &raw_image_)) 61 if (EncodeBGRAImageSkia(image_, false, &raw_image_))
53 has_raw_image_ = true; 62 has_raw_image_ = true;
54 } else { 63 } else {
55 has_raw_image_ = true; 64 has_raw_image_ = true;
56 raw_image_ = raw_image; 65 raw_image_ = raw_image;
57 } 66 }
58 } 67 }
59 68
60 UserImage::~UserImage() {} 69 UserImage::~UserImage() {}
61 70
62 void UserImage::DiscardRawImage() { 71 void UserImage::DiscardRawImage() {
63 RawImage().swap(raw_image_); // Clear |raw_image_|. 72 RawImage().swap(raw_image_); // Clear |raw_image_|.
64 } 73 }
65 74
66 } // namespace chromeos 75 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/background/background_mode_manager.cc ('k') | chrome/browser/media/media_stream_capture_indicator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698