Change panels to use gfx::Image instead of SkBitmap for favicon.

Change panels to use gfx::Image instead of SkBitmap for favicon.

Completes a TODO added in r149891.

BUG=None
TEST=open panels and verify favicons look correct


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151668

[jennb, 2012-08-09 21:22:12]

Hi Nico, want to review this given that you added the TODO I'm working on? ;-)

[Nico, 2012-08-10 18:17:33]

LGTM

Thanks for doing this!

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/ol...
File chrome/browser/ui/panels/old_panel.cc (right):

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/ol...
chrome/browser/ui/panels/old_panel.cc:66: // directly rather than use
browser_->GetCurrentPageIcon().
Add a TODO to undo this once Browser::GetCurrentPageIcon() is converted

[Robert Sesek, 2012-08-10 19:37:29]

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/pa...
File chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc (right):

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/pa...
chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc:246:
g_object_unref(icon_pixbuf);
The ToX functions return a weak reference, so this is unneeded and will result
in use-after-free. The CopyX functions return an object that the caller owns.

[jennb, 2012-08-11 04:20:05]

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/ol...
File chrome/browser/ui/panels/old_panel.cc (right):

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/ol...
chrome/browser/ui/panels/old_panel.cc:66: // directly rather than use
browser_->GetCurrentPageIcon().
On 2012/08/10 18:17:33, Nico wrote:
> Add a TODO to undo this once Browser::GetCurrentPageIcon() is converted

No need. This file will be deleted soon after the panels refactor is complete. I
only made this edit to get things compiling in the meanwhile.

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/pa...
File chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc (right):

http://codereview.chromium.org/10827259/diff/8003/chrome/browser/ui/panels/pa...
chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc:246:
g_object_unref(icon_pixbuf);
On 2012/08/10 19:37:29, rsesek wrote:
> The ToX functions return a weak reference, so this is unneeded and will result
> in use-after-free. The CopyX functions return an object that the caller owns.

Thanks for pointing this out. Maybe this explains why some tests are failing.

[commit-bot: I haz the power, 2012-08-14 20:20:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10827259/3005

[commit-bot: I haz the power, 2012-08-14 20:54:00]

Try job failure for 10827259-3005 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-08-14 22:20:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10827259/15004

[commit-bot: I haz the power, 2012-08-15 02:50:00]

Try job failure for 10827259-15004 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-15 04:37:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10827259/15004

[commit-bot: I haz the power, 2012-08-15 06:22:50]

Change committed as 151668