Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/panels/panel_view.cc

Issue 10827259: Change panels to use gfx::Image instead of SkBitmap for favicon. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: applied change to panel_titlebar_gtk.cc after syncing Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/panel_view.h" 5 #include "chrome/browser/ui/panels/panel_view.h"
6 6
7 #include <map> 7 #include <map>
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/ui/panels/panel.h" 10 #include "chrome/browser/ui/panels/panel.h"
11 #include "chrome/browser/ui/panels/panel_bounds_animation.h" 11 #include "chrome/browser/ui/panels/panel_bounds_animation.h"
12 #include "chrome/browser/ui/panels/panel_frame_view.h" 12 #include "chrome/browser/ui/panels/panel_frame_view.h"
13 #include "chrome/browser/ui/panels/panel_manager.h" 13 #include "chrome/browser/ui/panels/panel_manager.h"
14 #include "content/public/browser/render_view_host.h" 14 #include "content/public/browser/render_view_host.h"
15 #include "content/public/browser/render_widget_host_view.h" 15 #include "content/public/browser/render_widget_host_view.h"
16 #include "ui/gfx/image/image.h"
16 #include "ui/gfx/path.h" 17 #include "ui/gfx/path.h"
17 #include "ui/gfx/screen.h" 18 #include "ui/gfx/screen.h"
18 #include "ui/views/controls/button/image_button.h" 19 #include "ui/views/controls/button/image_button.h"
19 #include "ui/views/controls/webview/webview.h" 20 #include "ui/views/controls/webview/webview.h"
20 #include "ui/views/widget/widget.h" 21 #include "ui/views/widget/widget.h"
21 22
22 #if defined(OS_WIN) && !defined(USE_ASH) && !defined(USE_AURA) 23 #if defined(OS_WIN) && !defined(USE_ASH) && !defined(USE_AURA)
23 #include "base/win/windows_version.h" 24 #include "base/win/windows_version.h"
24 #include "chrome/browser/ui/panels/taskbar_window_thumbnailer_win.h" 25 #include "chrome/browser/ui/panels/taskbar_window_thumbnailer_win.h"
25 #endif 26 #endif
(...skipping 471 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 498
498 bool PanelView::CanMaximize() const { 499 bool PanelView::CanMaximize() const {
499 return false; 500 return false;
500 } 501 }
501 502
502 string16 PanelView::GetWindowTitle() const { 503 string16 PanelView::GetWindowTitle() const {
503 return panel_->GetWindowTitle(); 504 return panel_->GetWindowTitle();
504 } 505 }
505 506
506 gfx::ImageSkia PanelView::GetWindowIcon() { 507 gfx::ImageSkia PanelView::GetWindowIcon() {
507 return panel_->GetCurrentPageIcon(); 508 gfx::Image icon = panel_->GetCurrentPageIcon();
509 return icon.IsEmpty() ? gfx::ImageSkia() : *icon.ToImageSkia();
508 } 510 }
509 511
510 void PanelView::DeleteDelegate() { 512 void PanelView::DeleteDelegate() {
511 delete this; 513 delete this;
512 } 514 }
513 515
514 void PanelView::OnWindowBeginUserBoundsChange() { 516 void PanelView::OnWindowBeginUserBoundsChange() {
515 panel_->OnPanelStartUserResizing(); 517 panel_->OnPanelStartUserResizing();
516 } 518 }
517 519
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 int height = web_view_->size().height(); 743 int height = web_view_->size().height();
742 SkRegion* region = new SkRegion; 744 SkRegion* region = new SkRegion;
743 region->op(0, 0, kResizeInsideBoundsSize, height, SkRegion::kUnion_Op); 745 region->op(0, 0, kResizeInsideBoundsSize, height, SkRegion::kUnion_Op);
744 region->op(width - kResizeInsideBoundsSize, 0, width, height, 746 region->op(width - kResizeInsideBoundsSize, 0, width, height,
745 SkRegion::kUnion_Op); 747 SkRegion::kUnion_Op);
746 region->op(0, height - kResizeInsideBoundsSize, width, height, 748 region->op(0, height - kResizeInsideBoundsSize, width, height,
747 SkRegion::kUnion_Op); 749 SkRegion::kUnion_Op);
748 web_contents->GetRenderViewHost()->GetView()->SetClickthroughRegion(region); 750 web_contents->GetRenderViewHost()->GetView()->SetClickthroughRegion(region);
749 #endif 751 #endif
750 } 752 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel_titlebar_gtk.cc ('k') | chrome/browser/ui/panels/panel_window_controller_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698