Update iossim.gyp to use src/build/ios/mac_build.gypi.

Update iossim.gyp to use src/build/ios/mac_build.gypi.

The mac_build.gypi will build the iossim executable using ninja.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152335

[stuartmorgan, 2012-08-07 17:40:37]

LGTM with nits

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
File testing/iossim/iossim.gyp (right):

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
testing/iossim/iossim.gyp:10: ['OS!="ios"', {
Let's do OS != "ios" (with spaces). It's not consistent in the code base, but I
find it more readable so I'd like to use it in new files.

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
testing/iossim/iossim.gyp:18:
'<(DEPTH)/testing/iossim/third_party/class-dump/class-dump.gyp:class-dump',
Since this is a gyp file, not a gypi file included in anything else, can't this
just be 'third_party/class-dump/...' ?

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
testing/iossim/iossim.gyp:44: '<(DEPTH)/testing/iossim/redirect-stdout.sh',
Same path comment here.

[lliabraa, 2012-08-16 15:40:59]

PTAL. I had to modify common.gypi so that the mac_sdk variable is set when
mac_build.gypi is processed.

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
File testing/iossim/iossim.gyp (right):

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
testing/iossim/iossim.gyp:10: ['OS!="ios"', {
On 2012/08/07 17:40:37, stuartmorgan wrote:
> Let's do OS != "ios" (with spaces). It's not consistent in the code base, but
I
> find it more readable so I'd like to use it in new files.

Done.

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
testing/iossim/iossim.gyp:18:
'<(DEPTH)/testing/iossim/third_party/class-dump/class-dump.gyp:class-dump',
On 2012/08/07 17:40:37, stuartmorgan wrote:
> Since this is a gyp file, not a gypi file included in anything else, can't
this
> just be 'third_party/class-dump/...' ?

Done.

https://chromiumcodereview.appspot.com/10827200/diff/3001/testing/iossim/ioss...
testing/iossim/iossim.gyp:44: '<(DEPTH)/testing/iossim/redirect-stdout.sh',
On 2012/08/07 17:40:37, stuartmorgan wrote:
> Same path comment here.

Done.

[stuartmorgan, 2012-08-20 07:29:53]

LGTM with comment nit.

https://chromiumcodereview.appspot.com/10827200/diff/1003/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10827200/diff/1003/build/common.gypi#n...
build/common.gypi:898: # allows specifying the sdk that will be used for mac
sub-builds.
Let's make this a bit clearer. How about:

The Mac SDK is set for iOS builds and passed through to Mac sub-builds. This
allows the Mac sub-build SDK in an iOS build to be overridden from the command
line the same way it is for a Mac build.

[lliabraa, 2012-08-20 13:47:42]

https://chromiumcodereview.appspot.com/10827200/diff/1003/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10827200/diff/1003/build/common.gypi#n...
build/common.gypi:898: # allows specifying the sdk that will be used for mac
sub-builds.
On 2012/08/20 07:29:53, stuartmorgan wrote:
> Let's make this a bit clearer. How about:
> 
> The Mac SDK is set for iOS builds and passed through to Mac sub-builds. This
> allows the Mac sub-build SDK in an iOS build to be overridden from the command
> line the same way it is for a Mac build.

Done.

[commit-bot: I haz the power, 2012-08-20 13:47:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10827200/6002

[commit-bot: I haz the power, 2012-08-20 16:28:13]

Change committed as 152335