Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: testing/iossim/iossim.gyp

Issue 10827200: Update iossim.gyp to use src/build/ios/mac_build.gypi. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fixed comment based on review feedback. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/gtest.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/iossim/iossim.gyp
diff --git a/testing/iossim/iossim.gyp b/testing/iossim/iossim.gyp
index a2f559c342fa10dc082149728ce328a78f60762b..2894be0f82b1df9560543b789a65979c17012be3 100644
--- a/testing/iossim/iossim.gyp
+++ b/testing/iossim/iossim.gyp
@@ -3,47 +3,90 @@
# found in the LICENSE file.
{
- 'variables': {
- 'iphone_sim_path': '$(DEVELOPER_DIR)/Platforms/iPhoneSimulator.platform/Developer/Library/PrivateFrameworks',
- 'other_frameworks_path': '$(DEVELOPER_DIR)/../OtherFrameworks'
- },
'targets': [
{
'target_name': 'iossim',
- 'type': 'executable',
- 'dependencies': [
- '<(DEPTH)/testing/iossim/third_party/class-dump/class-dump.gyp:class-dump',
- ],
- 'include_dirs': [
- '<(INTERMEDIATE_DIR)/iossim',
- ],
- 'sources': [
- 'iossim.mm',
- '<(INTERMEDIATE_DIR)/iossim/iPhoneSimulatorRemoteClient.h',
- ],
- 'libraries': [
- '$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
- ],
- 'actions': [
- {
- 'action_name': 'generate_iphone_sim_header',
- 'inputs': [
- '<(iphone_sim_path)/iPhoneSimulatorRemoteClient.framework/Versions/Current/iPhoneSimulatorRemoteClient',
- '$(BUILD_DIR)/$(CONFIGURATION)/class-dump',
+ 'conditions': [
+ ['OS != "ios"', {
+ 'type': 'executable',
+ 'variables': {
+ 'developer_dir': '<!(xcode-select -print-path)',
+ 'iphone_sim_path': '<(developer_dir)/Platforms/iPhoneSimulator.platform/Developer/Library/PrivateFrameworks',
+ 'other_frameworks_path': '<(developer_dir)/../OtherFrameworks'
+ },
+ 'dependencies': [
+ 'third_party/class-dump/class-dump.gyp:class-dump',
],
- 'outputs': [
- '<(INTERMEDIATE_DIR)/iossim/iPhoneSimulatorRemoteClient.h'
+ 'include_dirs': [
+ '<(INTERMEDIATE_DIR)/iossim',
],
- 'action': [
- # Actions don't provide a way to redirect stdout, so a custom
- # script is invoked that will execute the first argument and write
- # the output to the file specified as the second argument.
- '<(DEPTH)/testing/iossim/redirect-stdout.sh',
- '$(BUILD_DIR)/$(CONFIGURATION)/class-dump -CiPhoneSimulator <(iphone_sim_path)/iPhoneSimulatorRemoteClient.framework',
+ 'sources': [
+ 'iossim.mm',
'<(INTERMEDIATE_DIR)/iossim/iPhoneSimulatorRemoteClient.h',
],
- 'message': 'Generating header',
- },
+ 'libraries': [
+ '$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
+ ],
+ 'actions': [
+ {
+ 'action_name': 'generate_iphone_sim_header',
+ 'inputs': [
+ '<(iphone_sim_path)/iPhoneSimulatorRemoteClient.framework/Versions/Current/iPhoneSimulatorRemoteClient',
+ '<(PRODUCT_DIR)/class-dump',
+ ],
+ 'outputs': [
+ '<(INTERMEDIATE_DIR)/iossim/iPhoneSimulatorRemoteClient.h'
+ ],
+ 'action': [
+ # Actions don't provide a way to redirect stdout, so a custom
+ # script is invoked that will execute the first argument and write
+ # the output to the file specified as the second argument.
+ './redirect-stdout.sh',
+ '<(PRODUCT_DIR)/class-dump -CiPhoneSimulator <(iphone_sim_path)/iPhoneSimulatorRemoteClient.framework',
+ '<(INTERMEDIATE_DIR)/iossim/iPhoneSimulatorRemoteClient.h',
+ ],
+ 'message': 'Generating header',
+ },
+ ],
+ }, { # else, OS == "ios"
+ 'type': 'none',
+ 'variables': {
+ 'ninja_output_dir': 'ninja-iossim',
+ # Gyp to rerun
+ 're_run_targets': [
+ 'testing/iossim/iossim.gyp',
+ ],
+ },
+ 'includes': ['../../build/ios/mac_build.gypi'],
+ 'actions': [
+ {
+ 'action_name': 'compile iossim',
+ 'inputs': [],
+ 'outputs': [],
+ 'action': [
+ '<@(ninja_cmd)',
+ 'iossim',
+ ],
+ 'message': 'Generating the iossim executable',
+ },
+ {
+ 'action_name': 'copy iossim',
+ 'inputs': [
+ # TODO(ios): It should be possible to define the input, but
+ # adding it causes gyp to complain about duplicate id.
+ # '<(ninja_product_dir)/iossim',
+ ],
+ 'outputs': [
+ '<(DEPTH)/xcodebuild/<(CONFIGURATION_NAME)/iossim',
+ ],
+ 'action': [
+ 'cp',
+ '<(ninja_product_dir)/iossim',
+ '<(DEPTH)/xcodebuild/<(CONFIGURATION_NAME)/iossim',
+ ],
+ },
+ ],
+ }],
],
},
],
« no previous file with comments | « testing/gtest.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698