Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8510)

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc
index 82979b39b51cbfd624a5a8940e3b0749f927a8d4..682923f1cfa4920364824995f9bc8463fbb97d47 100644
--- a/chrome/browser/ui/views/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar_view.cc
@@ -765,13 +765,15 @@ void ToolbarView::Layout() {
app_menu_width, child_height);
}
-bool ToolbarView::HitTest(const gfx::Point& point) const {
+bool ToolbarView::HitTest(const gfx::Rect& rect) const {
// Don't take hits in our top shadow edge. Let them fall through to the
// tab strip above us.
- if (point.y() < kContentShadowHeight)
+ fprintf(stderr, "in toolbar_view\n");
+ if (rect.y() < kContentShadowHeight) {
tdanderson 2012/08/07 16:18:28 Should this instead be rect.y() + rect.height() ?
sky 2012/08/07 20:11:43 I think this one wants want like you have.
tdanderson 2012/08/08 23:47:51 Ok, I left this alone.
return false;
+ }
// Otherwise let our superclass take care of it.
- return AccessiblePaneView::HitTest(point);
+ return AccessiblePaneView::HitTest(rect);
}
void ToolbarView::OnPaint(gfx::Canvas* canvas) {

Powered by Google App Engine
This is Rietveld 408576698