Change View::HitTest to View::HitTestRect

chrome/browser/ui/views/toolbar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar_view.h"
 
 #include "base/i18n/number_formatting.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/command_updater.h"
@@ skipping 747 matching lines @@
   browser_actions_->Layout();
 
   // Extend the app menu to the screen's right edge in maximized mode just like
   // we extend the back button to the left edge.
   if (maximized)
     app_menu_width += kRightEdgeSpacing;
   app_menu_->SetBounds(browser_actions_->x() + browser_actions_width, child_y,
                        app_menu_width, child_height);
 }
 
-bool ToolbarView::HitTest(const gfx::Point& point) const {
+bool ToolbarView::HitTest(const gfx::Rect& rect) const {
   // Don't take hits in our top shadow edge.  Let them fall through to the
   // tab strip above us.
-  if (point.y() < kContentShadowHeight)
+  fprintf(stderr, "in toolbar_view\n");
+  if (rect.y() < kContentShadowHeight) {

[tdanderson, 2012/08/07 16:18:28]

Should this instead be rect.y() + rect.height() ?

[sky, 2012/08/07 20:11:43]

I think this one wants want like you have.

[tdanderson, 2012/08/08 23:47:51]

Ok, I left this alone.

     return false;
+  }
   // Otherwise let our superclass take care of it.
-  return AccessiblePaneView::HitTest(point);
+  return AccessiblePaneView::HitTest(rect);
 }
 
 void ToolbarView::OnPaint(gfx::Canvas* canvas) {
   View::OnPaint(canvas);
 
   if (is_display_mode_normal())
     return;
 
   // In maximized mode, we don't draw the endcaps on the location bar, because
   // when they're flush against the edge of the screen they just look glitchy.
@@ skipping 229 matching lines @@
   // LocationBarContainer is not a child of the ToolbarView.
   gfx::Point origin(bounds.origin());
   views::View::ConvertPointToView(this, location_bar_container_->parent(),
                                   &origin);
   gfx::Rect target_bounds(origin, bounds.size());
   if (location_bar_container_->GetTargetBounds() != target_bounds) {
     location_bar_container_->SetInToolbar(true);
     location_bar_container_->SetBoundsRect(target_bounds);
   }
 }