Issue 10827073: Relanding 148377 - [Android] Upstream additional changes from envsetup."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827073: Relanding 148377 - [Android] Upstream additional changes from envsetup." (Closed)

Created:
8 years, 4 months ago by Yaron

Modified:
8 years, 4 months ago

Reviewers:
Peter Beverloo, Satish

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Relanding 148377 - [Android] Upstream additional changes from envsetup. Now requires you to specifically change the GYP_GENERATORS to specify Ninja. The original change broke because gyp ran for both make and ninja and the webkit bot determines whether to use ninja by the presence of build.ninja (thanks to Peter for figuring this out) BUG=137569, 136693 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148790

Patch Set 1 #

Patch Set 2 : remove ninja from generators list #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+487 lines, -116 lines)			Patch
A	build/android/adb_device_functions.sh	View		1 chunk	+133 lines, -0 lines	0 comments	Download
M	build/android/envsetup.sh	View		4 chunks	+55 lines, -110 lines	0 comments	Download
A	build/android/envsetup_functions.sh	View	1	1 chunk	+292 lines, -0 lines	0 comments	Download
M	build/common.gypi	View		4 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yaron

I'm still not sure why this only affected the webkit bot (probably worth looking into ...

8 years, 4 months ago (2012-07-27 16:47:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10827073/2001

8 years, 4 months ago (2012-07-27 17:15:23 UTC) #4

Change committed as 148790

Expand Messages | Collapse Messages