Remove autogeneration of TEST= and automated check

Remove autogeneration of TEST= and automated check

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148672

[jamesr, 2012-07-27 00:02:54]

I couldn't find any autogeneration code in gcl.py, is it hidden somewhere or
does it only exist in git cl?

[M-A Ruel, 2012-07-27 00:05:26]

Pro-tip: when you put R=maruel@chromium.org in the CL description with git-cl,
if you use git cl upload --send-mail, it will set the proper reviewer right
away, directly from the command line.

https://chromiumcodereview.appspot.com/10827059/diff/1/presubmit_canned_check...
File presubmit_canned_checks.py (left):

https://chromiumcodereview.appspot.com/10827059/diff/1/presubmit_canned_check...
presubmit_canned_checks.py:13: def CheckChangeHasTestField(input_api,
output_api):
Do not remove it. This would break current users.

[jamesr, 2012-07-27 00:08:49]

On 2012/07/27 00:05:26, Marc-Antoine Ruel wrote:
> Pro-tip: when you put mailto:R=maruel@chromium.org in the CL description with
git-cl,
> if you use git cl upload --send-mail, it will set the proper reviewer right
> away, directly from the command line.

Oh, good tip.

> 
>
https://chromiumcodereview.appspot.com/10827059/diff/1/presubmit_canned_check...
> File presubmit_canned_checks.py (left):
> 
>
https://chromiumcodereview.appspot.com/10827059/diff/1/presubmit_canned_check...
> presubmit_canned_checks.py:13: def CheckChangeHasTestField(input_api,
> output_api):
> Do not remove it. This would break current users.

Ah right, because depot_tools updates faster than people's chromium checkouts. 
Is it safe to remove after some period of time or should depot_tools work with
any version of chromium's PRESUBMIT.py ?

[M-A Ruel, 2012-07-27 00:12:01]

On 2012/07/27 00:08:49, jamesr wrote:
> On 2012/07/27 00:05:26, Marc-Antoine Ruel wrote:
>
https://chromiumcodereview.appspot.com/10827059/diff/1/presubmit_canned_check...
> > presubmit_canned_checks.py:13: def CheckChangeHasTestField(input_api,
> > output_api):
> > Do not remove it. This would break current users.
> 
> Ah right, because depot_tools updates faster than people's chromium checkouts.

> Is it safe to remove after some period of time or should depot_tools work with
> any version of chromium's PRESUBMIT.py ?

depot_tools needs to be backward compatible so you can sync to an older version.
In general, at least for ~6 months of code but that's not an hard rule. It can
safely stay there.

[jamesr, 2012-07-27 00:16:18]

PTAL

[M-A Ruel, 2012-07-27 00:17:55]

lgtm

[commit-bot: I haz the power, 2012-07-27 00:18:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/10827059/3002

[commit-bot: I haz the power, 2012-07-27 00:20:44]

Change committed as 148672