Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: tests/git_cl_test.py

Issue 10827059: Remove autogeneration of TEST= and automated check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
===================================================================
--- tests/git_cl_test.py (revision 148624)
+++ tests/git_cl_test.py (working copy)
@@ -253,14 +253,14 @@
def test_no_reviewer(self):
self._run_reviewer_test(
[],
- 'desc\n\nBUG=\nTEST=\n',
- '# Blah blah comment.\ndesc\n\nBUG=\nTEST=\n',
- 'desc\n\nBUG=\nTEST=\n',
+ 'desc\n\nBUG=\n',
+ '# Blah blah comment.\ndesc\n\nBUG=\n',
+ 'desc\n\nBUG=\n',
[])
def test_reviewers_cmd_line(self):
# Reviewer is passed as-is
- description = 'desc\n\nR=foo@example.com\nBUG=\nTEST=\n'
+ description = 'desc\n\nR=foo@example.com\nBUG=\n'
self._run_reviewer_test(
['-r' 'foo@example.com'],
description,
@@ -274,7 +274,7 @@
description = 'Foo Bar\nTBR=reviewer@example.com\n'
self._run_reviewer_test(
['-r' 'foo@example.com'],
- 'desc\n\nR=foo@example.com\nBUG=\nTEST=\n',
+ 'desc\n\nR=foo@example.com\nBUG=\n',
description.strip('\n'),
description,
['--reviewers', 'reviewer@example.com'])
@@ -285,7 +285,7 @@
'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n')
self._run_reviewer_test(
[],
- 'desc\n\nBUG=\nTEST=\n',
+ 'desc\n\nBUG=\n',
description,
description,
['--reviewers', 'reviewer@example.com,another@example.com'])
@@ -295,7 +295,7 @@
description = 'Foo Bar\nR=reviewer@example.com\n'
self._run_reviewer_test(
['--send-mail'],
- 'desc\n\nBUG=\nTEST=\n',
+ 'desc\n\nBUG=\n',
description.strip('\n'),
description,
['--reviewers', 'reviewer@example.com', '--send_mail'])
@@ -390,13 +390,13 @@
def test_gerrit_no_reviewer(self):
self._run_gerrit_reviewer_test(
[],
- 'desc\n\nBUG=\nTEST=\n',
+ 'desc\n\nBUG=\n',
[])
def test_gerrit_reviewers_cmd_line(self):
self._run_gerrit_reviewer_test(
['-r', 'foo@example.com'],
- 'desc\n\nBUG=\nTEST=\n',
+ 'desc\n\nBUG=\n',
['foo@example.com'])
def test_gerrit_reviewer_multiple(self):
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698