Issue 10827018: gdata: Rename functions in GDataAuthService per OAuth2 terminology

Issue 10827018: gdata: Rename functions in GDataAuthService per OAuth2 terminology (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
achuithb, Daniel Erat

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Rename functions in GDataAuthService per OAuth2 terminology This is based on a suggestion from derat@ at http://codereview.chromium.org/10808108/ Reference: http://code.google.com/apis/accounts/docs/OAuth2WebServer.html BUG=none TEST=out/Release/unit_tests --gtest_filter='GData*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148540

Patch Set 4 : address comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -44 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_auth_service.h	View	1 2 3	2 chunks	+15 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_auth_service.cc	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_documents_service.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_documents_service.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_documents_service_browsertest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_operation_runner.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_documents_service.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/operations_base.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/operations_base.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

achuithb

http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gdata/gdata_documents_service.h File chrome/browser/chromeos/gdata/gdata_documents_service.h (right): http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gdata/gdata_documents_service.h#newcode189 chrome/browser/chromeos/gdata/gdata_documents_service.h:189: virtual bool HasAccessToken() const = 0; Who uses this? ...

8 years, 5 months ago (2012-07-25 21:56:25 UTC) #3

satorux1

On 2012/07/25 21:56:25, achuith.bhandarkar wrote: > http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gdata/gdata_documents_service.h > File chrome/browser/chromeos/gdata/gdata_documents_service.h (right): > > http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gdata/gdata_documents_service.h#newcode189 > ...

8 years, 5 months ago (2012-07-25 22:05:14 UTC) #4

Daniel Erat

lgtm http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gdata/gdata_auth_service.h File chrome/browser/chromeos/gdata/gdata_auth_service.h (right): http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gdata/gdata_auth_service.h#newcode57 chrome/browser/chromeos/gdata/gdata_auth_service.h:57: // True if OAuth2 access token is retrieved ...

8 years, 5 months ago (2012-07-25 22:07:30 UTC) #5

satorux1

8 years, 5 months ago (2012-07-25 22:21:21 UTC) #6

http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_auth_service.h (right):

http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_auth_service.h:57: // True if OAuth2 access
token is retrieved and believed to be fresh.
On 2012/07/25 22:07:31, Daniel Erat wrote:
> nit: s/if /if an/

Done.

http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_auth_service.h:61: // True if OAuth2 refresh
token is present. It's absence means that user
On 2012/07/25 22:07:31, Daniel Erat wrote:
> nit: s/if /if an/, s/It's/its/

Done.

http://codereview.chromium.org/10827018/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_auth_service.h:61: // True if OAuth2 refresh
token is present. It's absence means that user
On 2012/07/25 22:07:31, Daniel Erat wrote:
> nit: s/if /if an/, s/It's/its/

Done.

Expand Messages | Collapse Messages