Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/chromeos/gdata/gdata_auth_service.h

Issue 10827018: gdata: Rename functions in GDataAuthService per OAuth2 terminology (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_auth_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_auth_service.h
diff --git a/chrome/browser/chromeos/gdata/gdata_auth_service.h b/chrome/browser/chromeos/gdata/gdata_auth_service.h
index d058530a179b55859b3504e2a54a116e61da169e..1acfac25a08fdf4cf56bd320b09579436dd9d796 100644
--- a/chrome/browser/chromeos/gdata/gdata_auth_service.h
+++ b/chrome/browser/chromeos/gdata/gdata_auth_service.h
@@ -54,36 +54,35 @@ class GDataAuthService : public content::NotificationObserver {
void StartAuthentication(GDataOperationRegistry* registry,
const AuthStatusCallback& callback);
- // True if OAuth2 auth token is retrieved and believed to be fresh.
- bool IsFullyAuthenticated() const { return !auth_token_.empty(); }
+ // True if an OAuth2 access token is retrieved and believed to be fresh.
+ // The access token is used to access the gdata server.
+ bool HasAccessToken() const { return !access_token_.empty(); }
- // True if OAuth2 refresh token is present. It's absence means that user
+ // True if an OAuth2 refresh token is present. Its absence means that user
// is not properly authenticated.
- bool IsPartiallyAuthenticated() const { return !refresh_token_.empty(); }
+ // The refresh token is used to get the access token.
+ bool HasRefreshToken() const { return !refresh_token_.empty(); }
- // Gets OAuth2 auth token.
- const std::string& oauth2_auth_token() const { return auth_token_; }
+ // Returns OAuth2 access token.
+ const std::string& access_token() const { return access_token_; }
- // Clears OAuth2 token.
- void ClearOAuth2Token() { auth_token_.clear(); }
-
- // Gets OAuth2 refresh token.
- const std::string& GetOAuth2RefreshToken() { return refresh_token_; }
+ // Clears OAuth2 access token.
+ void ClearAccessToken() { access_token_.clear(); }
// Callback for AuthOperation (InternalAuthStatusCallback).
void OnAuthCompleted(scoped_refptr<base::MessageLoopProxy> relay_proxy,
const AuthStatusCallback& callback,
GDataErrorCode error,
- const std::string& auth_token);
+ const std::string& access_token);
// Overridden from content::NotificationObserver:
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // Sets the auth_token as specified. This should be used only for testing.
- void set_oauth2_auth_token_for_testing(const std::string& token) {
- auth_token_ = token;
+ // Sets the access_token as specified. This should be used only for testing.
+ void set_access_token_for_testing(const std::string& token) {
+ access_token_ = token;
}
private:
@@ -95,7 +94,7 @@ class GDataAuthService : public content::NotificationObserver {
Profile* profile_;
std::string refresh_token_;
- std::string auth_token_;
+ std::string access_token_;
ObserverList<Observer> observers_;
content::NotificationRegistrar registrar_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_auth_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698