Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 10826271: Fix a potential access violation in the destructor of OmniboxViewWin. (Closed)

Created:
8 years, 4 months ago by robertshield
Modified:
8 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su
Visibility:
Public.

Description

Fix a potential access violation in the destructor of OmniboxViewWin. If an OmniboxViewWin is created then destroyed without being used in the interim, the destructor would dereference a null pointer. Discovered while writing https://chromiumcodereview.appspot.com/10854017 BUG=NONE TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
robertshield
8 years, 4 months ago (2012-08-13 13:46:30 UTC) #1
Peter Kasting
LGTM, good catch! It seems unlikely this has caused real crashes since practically anything the ...
8 years, 4 months ago (2012-08-14 18:19:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10826271/1
8 years, 4 months ago (2012-08-14 19:01:58 UTC) #3
commit-bot: I haz the power
Try job failure for 10826271-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-14 20:40:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10826271/1
8 years, 4 months ago (2012-08-14 21:10:04 UTC) #5
commit-bot: I haz the power
Try job failure for 10826271-1 (retry) on linux_chromeos for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-15 01:30:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10826271/1
8 years, 4 months ago (2012-08-15 02:04:39 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 03:30:15 UTC) #8
Try job failure for 10826271-1 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698