Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 10854017: Basic metro snap view omnibox. (Closed)

Created:
8 years, 4 months ago by robertshield
Modified:
8 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chrome-win8-eng_google.com
Visibility:
Public.

Description

Implementation of basic metro snap view omnibox. When snapped to a 20% view, the omnibox is now made visible, but disabled. When unsnapped, the original location bar is restored. Also fixes an access violation in omnibox_view_win. BUG=141546

Patch Set 1 #

Patch Set 2 : Omnibox now correctly disabled, clicking unsnaps, more general plumbing. Unsnapping doesn't restore… #

Patch Set 3 : Reset location bar view mode on unsnap. #

Patch Set 4 : Correct lifecycle handling for location bar views. #

Patch Set 5 : Shorten some code. Fix pre-existing omnibox access violation. #

Patch Set 6 : Deal with merge fallout. Some spit and polish. #

Patch Set 7 : Fix chromeos compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -51 lines) Patch
M base/win/metro.h View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_container.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_container.cc View 1 2 3 4 5 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 5 6 6 chunks +29 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.h View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 2 3 4 5 8 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_views.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_views.cc View 1 1 chunk +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 2 3 4 5 4 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 3 4 5 6 3 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
robertshield
Hi Scott, Please could you take a look at this change for adding an address ...
8 years, 4 months ago (2012-08-11 02:33:50 UTC) #1
tfarina
On 2012/08/11 02:33:50, robertshield wrote: > Also fixes an access violation in omnibox_view_win. Can this ...
8 years, 4 months ago (2012-08-11 02:39:31 UTC) #2
robertshield
On 2012/08/11 02:39:31, tfarina wrote: > On 2012/08/11 02:33:50, robertshield wrote: > > Also fixes ...
8 years, 4 months ago (2012-08-13 13:49:15 UTC) #3
robertshield
Peter, Thiago suggested I should run the Omnibox stuff by you too. Would you mind ...
8 years, 4 months ago (2012-08-13 13:50:58 UTC) #4
sky
You don't need both Peter and myself. I'm removing myself.
8 years, 4 months ago (2012-08-13 14:54:40 UTC) #5
robertshield
On 2012/08/13 14:54:40, sky wrote: > You don't need both Peter and myself. I'm removing ...
8 years, 4 months ago (2012-08-14 17:23:40 UTC) #6
Peter Kasting
So is this dead now?
8 years, 3 months ago (2012-08-28 01:56:15 UTC) #7
robertshield
8 years, 3 months ago (2012-08-28 01:57:42 UTC) #8
On 2012/08/28 01:56:15, Peter Kasting wrote:
> So is this dead now?

Yep, sounds like. Many thanks for taking a look. At least one small bug fix came
out of it :)

Powered by Google App Engine
This is Rietveld 408576698