Implementation of basic metro snap view omnibox.
When snapped to a 20% view, the omnibox is now made visible, but disabled. When unsnapped, the original location bar is restored.
Also fixes an access violation in omnibox_view_win.
BUG=141546
Hi Scott, Please could you take a look at this change for adding an address ...
8 years, 4 months ago
(2012-08-11 02:33:50 UTC)
#1
Hi Scott,
Please could you take a look at this change for adding an address bar to metro
snap mode?
Thanks!
Robert
tfarina
On 2012/08/11 02:33:50, robertshield wrote: > Also fixes an access violation in omnibox_view_win. Can this ...
8 years, 4 months ago
(2012-08-11 02:39:31 UTC)
#2
On 2012/08/11 02:33:50, robertshield wrote:
> Also fixes an access violation in omnibox_view_win.
Can this be made separated? So it's clear what fixes this access violation?
Probably Peter or Mike (msw) should look at this as well.
robertshield
On 2012/08/11 02:39:31, tfarina wrote: > On 2012/08/11 02:33:50, robertshield wrote: > > Also fixes ...
8 years, 4 months ago
(2012-08-13 13:49:15 UTC)
#3
On 2012/08/11 02:39:31, tfarina wrote:
> On 2012/08/11 02:33:50, robertshield wrote:
> > Also fixes an access violation in omnibox_view_win.
> Can this be made separated? So it's clear what fixes this access violation?
> Probably Peter or Mike (msw) should look at this as well.
Thanks Thiago, sent Peter a CL for the omnibox fix, I'll leave the code here as
well until the other is committed since this exposes the crash quite readily.
robertshield
Peter, Thiago suggested I should run the Omnibox stuff by you too. Would you mind ...
8 years, 4 months ago
(2012-08-13 13:50:58 UTC)
#4
Peter, Thiago suggested I should run the Omnibox stuff by you too. Would you
mind taking a peek?
sky
You don't need both Peter and myself. I'm removing myself.
8 years, 4 months ago
(2012-08-13 14:54:40 UTC)
#5
You don't need both Peter and myself. I'm removing myself.
robertshield
On 2012/08/13 14:54:40, sky wrote: > You don't need both Peter and myself. I'm removing ...
8 years, 4 months ago
(2012-08-14 17:23:40 UTC)
#6
On 2012/08/13 14:54:40, sky wrote:
> You don't need both Peter and myself. I'm removing myself.
@Peter: ping :)
Peter Kasting
So is this dead now?
8 years, 3 months ago
(2012-08-28 01:56:15 UTC)
#7
So is this dead now?
robertshield
On 2012/08/28 01:56:15, Peter Kasting wrote: > So is this dead now? Yep, sounds like. ...
8 years, 3 months ago
(2012-08-28 01:57:42 UTC)
#8
On 2012/08/28 01:56:15, Peter Kasting wrote:
> So is this dead now?
Yep, sounds like. Many thanks for taking a look. At least one small bug fix came
out of it :)
Issue 10854017: Basic metro snap view omnibox.
(Closed)
Created 8 years, 4 months ago by robertshield
Modified 8 years, 3 months ago
Reviewers: Peter Kasting
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0