Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10826125: Properly update chromedriver. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
===================================================================
--- tools/testing/perf_testing/run_perf_tests.py (revision 10196)
+++ tools/testing/perf_testing/run_perf_tests.py (working copy)
@@ -727,6 +727,10 @@
self.add_svn_revision_to_trace(self.test.trace_file, browser)
file_path = '"%s"' % os.path.join(os.getcwd(), dromaeo_path,
'index-js.html?%s' % version)
+ if platform.system() == 'Windows':
+ file_path = file_path.replace('&', '^&')
+ file_path = file_path.replace('?', '^?')
+ file_path = file_path.replace('|', '^|')
self.test.test_runner.run_cmd(
['python', os.path.join('tools', 'testing', 'run_selenium.py'),
'--out', file_path, '--browser', browser,
@@ -1078,7 +1082,7 @@
results = set()
pickle.dump(results, f)
f.close()
- f = open(filename)
+ f = open(filename, '+r')
result_set = pickle.load(f)
if revision_num:
f.seek(0)
@@ -1122,9 +1126,6 @@
if run == 0:
has_run_extra = True
results_set = update_set_of_done_cls(revision_num)
- elif run == -1:
- # This revision is a broken build. Don't try to run it again.
- results_set = update_set_of_done_cls(revision_num)
revision_num -= 1
# No more extra back-runs to do (for now). Wait for new code.
time.sleep(200)
« no previous file with comments | « no previous file | tools/testing/webdriver_test_setup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698