Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: tools/testing/webdriver_test_setup.py

Issue 10826125: Properly update chromedriver. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/perf_testing/run_perf_tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/webdriver_test_setup.py
===================================================================
--- tools/testing/webdriver_test_setup.py (revision 10196)
+++ tools/testing/webdriver_test_setup.py (working copy)
@@ -16,6 +16,7 @@
import os
import platform
import re
+import shutil
import subprocess
import sys
import urllib
@@ -141,6 +142,17 @@
z.extractall(self.download_location)
z.close()
os.remove(os.path.join(self.download_location, download_name))
+ chrome_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
+ 'orig-chromedriver')
+ if self.project_name == 'chromedriver' and os.path.exists(chrome_path):
+ # We have one additional location to make sure chromedriver is updated.
+ # TODO(efortuna): Remove this. See move_chrome_driver_if_needed in
+ # perf_testing/run_perf_tests.py
+ driver = 'chromedriver'
+ if platform.system() == 'Windows':
+ driver += '.exe'
+ shutil.copy(os.path.join(self.download_location, driver),
+ os.path.join(chrome_path, driver))
@property
def get_os_str(self):
« no previous file with comments | « tools/testing/perf_testing/run_perf_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698