Issue 10826098: Use std::string for decryption key ID in webm parser.

Issue 10826098: Use std::string for decryption key ID in webm parser. (Closed)

Created:
8 years, 4 months ago by xhwang

Modified:
8 years, 4 months ago

Reviewers:
ddorwin, scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use std::string for decryption key ID in webm parser. TBR=ddorwin@chromium.org BUG=130689 TEST=media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149556

Patch Set 2 : Resolve comment. #

Patch Set 3 : Rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -59 lines)			Patch
M	media/webm/webm_cluster_parser.h	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download
M	media/webm/webm_cluster_parser.cc	View	1	5 chunks	+7 lines, -14 lines	0 comments	Download
M	media/webm/webm_cluster_parser_unittest.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	media/webm/webm_content_encodings.h	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	media/webm/webm_content_encodings.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	media/webm/webm_content_encodings_client.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	media/webm/webm_content_encodings_client_unittest.cc	View		5 chunks	+5 lines, -9 lines	0 comments	Download
M	media/webm/webm_stream_parser.cc	View	1 2	2 chunks	+9 lines, -7 lines	0 comments	Download
M	media/webm/webm_tracks_parser.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	media/webm/webm_tracks_parser.cc	View	1 2	1 chunk	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

xhwang

http://codereview.chromium.org/10826098/diff/1/media/webm/webm_cluster_parser_unittest.cc File media/webm/webm_cluster_parser_unittest.cc (right): http://codereview.chromium.org/10826098/diff/1/media/webm/webm_cluster_parser_unittest.cc#newcode5 media/webm/webm_cluster_parser_unittest.cc:5: #include <algorithm> for std::min()

8 years, 4 months ago (2012-08-01 17:18:33 UTC) #2

scherkus (not reviewing)

lgtm w/ nit! woohoo! http://codereview.chromium.org/10826098/diff/1/media/webm/webm_cluster_parser.cc File media/webm/webm_cluster_parser.cc (right): http://codereview.chromium.org/10826098/diff/1/media/webm/webm_cluster_parser.cc#newcode219 media/webm/webm_cluster_parser.cc:219: !video_encryption_key_id_.empty(); this should be 4-space ...

8 years, 4 months ago (2012-08-01 21:39:28 UTC) #3

xhwang

http://codereview.chromium.org/10826098/diff/1/media/webm/webm_cluster_parser.cc File media/webm/webm_cluster_parser.cc (right): http://codereview.chromium.org/10826098/diff/1/media/webm/webm_cluster_parser.cc#newcode219 media/webm/webm_cluster_parser.cc:219: !video_encryption_key_id_.empty(); On 2012/08/01 21:39:28, scherkus wrote: > this should ...

8 years, 4 months ago (2012-08-01 22:01:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/10826098/6001

8 years, 4 months ago (2012-08-01 22:20:07 UTC) #5

Change committed as 149556

Expand Messages | Collapse Messages