Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: media/webm/webm_stream_parser.cc

Issue 10826098: Use std::string for decryption key ID in webm parser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/webm/webm_content_encodings_client_unittest.cc ('k') | media/webm/webm_tracks_parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/webm/webm_stream_parser.h" 5 #include "media/webm/webm_stream_parser.h"
6 6
7 #include <string>
8
7 #include "base/callback.h" 9 #include "base/callback.h"
8 #include "base/logging.h" 10 #include "base/logging.h"
9 #include "media/ffmpeg/ffmpeg_common.h" 11 #include "media/ffmpeg/ffmpeg_common.h"
10 #include "media/filters/ffmpeg_glue.h" 12 #include "media/filters/ffmpeg_glue.h"
11 #include "media/filters/in_memory_url_protocol.h" 13 #include "media/filters/in_memory_url_protocol.h"
12 #include "media/webm/webm_cluster_parser.h" 14 #include "media/webm/webm_cluster_parser.h"
13 #include "media/webm/webm_constants.h" 15 #include "media/webm/webm_constants.h"
14 #include "media/webm/webm_content_encodings.h" 16 #include "media/webm/webm_content_encodings.h"
15 #include "media/webm/webm_info_parser.h" 17 #include "media/webm/webm_info_parser.h"
16 #include "media/webm/webm_tracks_parser.h" 18 #include "media/webm/webm_tracks_parser.h"
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 return -1; 352 return -1;
351 } 353 }
352 354
353 if (!config_cb_.Run(config_helper.audio_config(), 355 if (!config_cb_.Run(config_helper.audio_config(),
354 config_helper.video_config())) { 356 config_helper.video_config())) {
355 DVLOG(1) << "New config data isn't allowed."; 357 DVLOG(1) << "New config data isn't allowed.";
356 return -1; 358 return -1;
357 } 359 }
358 360
359 // TODO(xhwang): Support decryption of audio (see http://crbug.com/123421). 361 // TODO(xhwang): Support decryption of audio (see http://crbug.com/123421).
360 if (tracks_parser.video_encryption_key_id()) { 362 if (!tracks_parser.video_encryption_key_id().empty()) {
361 int key_id_size = tracks_parser.video_encryption_key_id_size(); 363 std::string key_id = tracks_parser.video_encryption_key_id();
364 int key_id_size = key_id.size();
362 CHECK_GT(key_id_size, 0); 365 CHECK_GT(key_id_size, 0);
363 CHECK_LT(key_id_size, 2048); 366 CHECK_LT(key_id_size, 2048);
364 scoped_array<uint8> key_id(new uint8[key_id_size]); 367 scoped_array<uint8> key_id_array(new uint8[key_id_size]);
365 memcpy(key_id.get(), tracks_parser.video_encryption_key_id(), key_id_size); 368 memcpy(key_id_array.get(), key_id.data(), key_id_size);
366 need_key_cb_.Run(key_id.Pass(), key_id_size); 369 need_key_cb_.Run(key_id_array.Pass(), key_id_size);
367 } 370 }
368 371
369 cluster_parser_.reset(new WebMClusterParser( 372 cluster_parser_.reset(new WebMClusterParser(
370 info_parser.timecode_scale(), 373 info_parser.timecode_scale(),
371 tracks_parser.audio_track_num(), 374 tracks_parser.audio_track_num(),
372 tracks_parser.video_track_num(), 375 tracks_parser.video_track_num(),
373 tracks_parser.video_encryption_key_id(), 376 tracks_parser.video_encryption_key_id()));
374 tracks_parser.video_encryption_key_id_size()));
375 377
376 ChangeState(kParsingClusters); 378 ChangeState(kParsingClusters);
377 379
378 if (!init_cb_.is_null()) { 380 if (!init_cb_.is_null()) {
379 init_cb_.Run(true, duration); 381 init_cb_.Run(true, duration);
380 init_cb_.Reset(); 382 init_cb_.Reset();
381 } 383 }
382 384
383 return bytes_parsed; 385 return bytes_parsed;
384 } 386 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 if (!video_buffers.empty() && !video_cb_.Run(video_buffers)) 434 if (!video_buffers.empty() && !video_cb_.Run(video_buffers))
433 return -1; 435 return -1;
434 436
435 if (cluster_ended) 437 if (cluster_ended)
436 end_of_segment_cb_.Run(); 438 end_of_segment_cb_.Run();
437 439
438 return bytes_parsed; 440 return bytes_parsed;
439 } 441 }
440 442
441 } // namespace media 443 } // namespace media
OLDNEW
« no previous file with comments | « media/webm/webm_content_encodings_client_unittest.cc ('k') | media/webm/webm_tracks_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698