Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: remoting/base/decoder_vp8_unittest.cc

Issue 10826062: [Chromoting] Disable a unit test in which win_tsan and mac_valgrind catch leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/decoder_vp8_unittest.cc
diff --git a/remoting/base/decoder_vp8_unittest.cc b/remoting/base/decoder_vp8_unittest.cc
index ab0607fc35135b4aebce6e23797fbca8ddbc45bc..385215839ca97b2be8acedf33254f25557b24d81 100644
--- a/remoting/base/decoder_vp8_unittest.cc
+++ b/remoting/base/decoder_vp8_unittest.cc
@@ -56,10 +56,11 @@ TEST_F(DecoderVp8Test, GradientScaleDownEvenToEven) {
TestGradient(320, 240, 160, 120, 0.04, 0.02);
}
-TEST_F(DecoderVp8Test, GradientScaleDownEvenToOdd) {
- // TODO(simonmorris): The maximum error is non-deterministic.
- // The mean error is not too high, which suggests that the problem is
- // restricted to a small area of the output image. See crbug.com/139437.
+// TODO(simonmorris): win_tsan and mac_valgrind catch leaks in this test.
+// The maximum error is non-deterministic. The mean error is not too high,
Sergey Ulanov 2012/07/30 17:36:35 might be better to have separate TODO() and open a
simonmorris 2012/07/30 17:58:52 It's almost certainly the same problem. I should h
+// which suggests that the problem is restricted to a small area of the output
+// image. See crbug.com/139437.
+TEST_F(DecoderVp8Test, DISABLED_GradientScaleDownEvenToOdd) {
TestGradient(320, 240, 161, 121, 1.0, 0.02);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698