Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: remoting/base/decoder_vp8_unittest.cc

Issue 10826062: [Chromoting] Disable a unit test in which win_tsan and mac_valgrind catch leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/video_frame.h" 5 #include "media/base/video_frame.h"
6 #include "remoting/base/codec_test.h" 6 #include "remoting/base/codec_test.h"
7 #include "remoting/base/decoder_vp8.h" 7 #include "remoting/base/decoder_vp8.h"
8 #include "remoting/base/encoder_vp8.h" 8 #include "remoting/base/encoder_vp8.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 } 49 }
50 50
51 TEST_F(DecoderVp8Test, GradientScaleUpOddToOdd) { 51 TEST_F(DecoderVp8Test, GradientScaleUpOddToOdd) {
52 TestGradient(321, 241, 641, 481, 0.04, 0.02); 52 TestGradient(321, 241, 641, 481, 0.04, 0.02);
53 } 53 }
54 54
55 TEST_F(DecoderVp8Test, GradientScaleDownEvenToEven) { 55 TEST_F(DecoderVp8Test, GradientScaleDownEvenToEven) {
56 TestGradient(320, 240, 160, 120, 0.04, 0.02); 56 TestGradient(320, 240, 160, 120, 0.04, 0.02);
57 } 57 }
58 58
59 TEST_F(DecoderVp8Test, GradientScaleDownEvenToOdd) { 59 // TODO(simonmorris): win_tsan and mac_valgrind catch leaks in this test.
60 // TODO(simonmorris): The maximum error is non-deterministic. 60 // The maximum error is non-deterministic. The mean error is not too high,
Sergey Ulanov 2012/07/30 17:36:35 might be better to have separate TODO() and open a
simonmorris 2012/07/30 17:58:52 It's almost certainly the same problem. I should h
61 // The mean error is not too high, which suggests that the problem is 61 // which suggests that the problem is restricted to a small area of the output
62 // restricted to a small area of the output image. See crbug.com/139437. 62 // image. See crbug.com/139437.
63 TEST_F(DecoderVp8Test, DISABLED_GradientScaleDownEvenToOdd) {
63 TestGradient(320, 240, 161, 121, 1.0, 0.02); 64 TestGradient(320, 240, 161, 121, 1.0, 0.02);
64 } 65 }
65 66
66 TEST_F(DecoderVp8Test, GradientScaleDownOddToEven) { 67 TEST_F(DecoderVp8Test, GradientScaleDownOddToEven) {
67 TestGradient(321, 241, 160, 120, 0.04, 0.02); 68 TestGradient(321, 241, 160, 120, 0.04, 0.02);
68 } 69 }
69 70
70 TEST_F(DecoderVp8Test, GradientScaleDownOddToOdd) { 71 TEST_F(DecoderVp8Test, GradientScaleDownOddToOdd) {
71 TestGradient(321, 241, 161, 121, 0.04, 0.02); 72 TestGradient(321, 241, 161, 121, 0.04, 0.02);
72 } 73 }
73 74
74 } // namespace remoting 75 } // namespace remoting
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698