Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 10826062: [Chromoting] Disable a unit test in which win_tsan and mac_valgrind catch leaks. (Closed)

Created:
8 years, 4 months ago by simonmorris
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov, garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Disable a unit test in which win_tsan and mac_valgrind catch use of uninitialized memory. The unit test was added in r148888. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148969

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M remoting/base/decoder_vp8_unittest.cc View 1 chunk +5 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
simonmorris
ptal
8 years, 4 months ago (2012-07-30 16:13:30 UTC) #1
garykac
lgtm
8 years, 4 months ago (2012-07-30 16:14:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10826062/1
8 years, 4 months ago (2012-07-30 16:14:48 UTC) #3
Sergey Ulanov
Don't need to use CQ for things like this, better to dcommit to make the ...
8 years, 4 months ago (2012-07-30 17:36:35 UTC) #4
commit-bot: I haz the power
Change committed as 148969
8 years, 4 months ago (2012-07-30 17:36:44 UTC) #5
simonmorris
8 years, 4 months ago (2012-07-30 17:58:51 UTC) #6
http://codereview.chromium.org/10826062/diff/1/remoting/base/decoder_vp8_unit...
File remoting/base/decoder_vp8_unittest.cc (right):

http://codereview.chromium.org/10826062/diff/1/remoting/base/decoder_vp8_unit...
remoting/base/decoder_vp8_unittest.cc:60: // The maximum error is
non-deterministic. The mean error is not too high,
On 2012/07/30 17:36:35, sergeyu wrote:
> might be better to have separate TODO() and open another bug to track the
leak.

It's almost certainly the same problem. I should have said "use of uninitialized
memory", not "leak" - I've edited the CL.

Powered by Google App Engine
This is Rietveld 408576698