Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10826058: Fix Windows XP and Vista taskbar activation issue. (Closed)

Created:
8 years, 4 months ago by msw
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Fix Windows XP and Vista taskbar activation issue. On Windows XP and Vista, new windows don't indicate activation on the taskbar. (the window buttons should look "pressed" on launch and new window) This regression was introduced by http://crrev.com/104051 Limit the original fix for http://crbug.com/90386 to Windows > Vista. BUG=90386, 123473 TEST=New Chrome window appear "pressed" on the taskbar on Vista and XP. No regressions (especially not of crbug.com/90386) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149215

Patch Set 1 : Restore NativeWidgetWin::OnNCActivate DefWindowProc call on XP and Vista. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/views/widget/native_widget_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Ben and Scott, please take a look; thanks! This fixes http://crbug.com/123473 on XP and ...
8 years, 4 months ago (2012-07-30 23:54:51 UTC) #1
msw
Cool, I just got to test the fix on PavanV's Vista machine. It looks good ...
8 years, 4 months ago (2012-07-31 02:58:16 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-31 15:49:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10826058/2001
8 years, 4 months ago (2012-07-31 16:05:58 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 17:47:58 UTC) #5
Change committed as 149215

Powered by Google App Engine
This is Rietveld 408576698