Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: ui/views/widget/native_widget_win.cc

Issue 10826058: Fix Windows XP and Vista taskbar activation issue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore NativeWidgetWin::OnNCActivate DefWindowProc call on XP and Vista. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_win.cc
diff --git a/ui/views/widget/native_widget_win.cc b/ui/views/widget/native_widget_win.cc
index 24273dd2f7afe41c74b025a0cc9ad32dd90b20ce..6c65886a37bae6d3869250366ccc58c9088ea296 100644
--- a/ui/views/widget/native_widget_win.cc
+++ b/ui/views/widget/native_widget_win.cc
@@ -1712,8 +1712,10 @@ LRESULT NativeWidgetWin::OnNCActivate(BOOL active) {
if (IsActive())
delegate_->EnableInactiveRendering();
- // Avoid DefWindowProc non-client rendering over our custom frame.
- if (!GetWidget()->ShouldUseNativeFrame()) {
+ // Avoid DefWindowProc non-client rendering over our custom frame on newer
+ // Windows versions only (breaks taskbar activation indication on XP/Vista).
+ if (!GetWidget()->ShouldUseNativeFrame() &&
+ base::win::GetVersion() > base::win::VERSION_VISTA) {
SetMsgHandled(TRUE);
return TRUE;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698