Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: tools/isolate/run_test_cases_smoke_test.py

Issue 10825448: Remove Retrying Failed Tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/run_test_cases.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/run_test_cases_smoke_test.py
diff --git a/tools/isolate/run_test_cases_smoke_test.py b/tools/isolate/run_test_cases_smoke_test.py
index 21744686cc87406a787edaf26d5025f3594f402e..5a17d40a32b5e9857256a89177517345eff8afdc 100755
--- a/tools/isolate/run_test_cases_smoke_test.py
+++ b/tools/isolate/run_test_cases_smoke_test.py
@@ -105,7 +105,13 @@ class TraceTestCases(unittest.TestCase):
self.assertEquals(1, return_code)
- test_fail_output = [
+ expected_out_re = [
+ r'\[\d/\d\] \d\.\d\ds .+',
+ r'\[\d/\d\] \d\.\d\ds .+',
+ r'\[\d/\d\] \d\.\d\ds .+',
+ r'\[\d/\d\] \d\.\d\ds .+',
+ r'\[\d/\d\] \d\.\d\ds .+',
+ r'\[\d/\d\] \d\.\d\ds .+',
re.escape('Note: Google Test filter = Baz.Fail'),
r'',
] + [
@@ -116,20 +122,7 @@ class TraceTestCases(unittest.TestCase):
] + [
re.escape(l) for l in gtest_fake_base.get_footer(1, 1).splitlines()
] + [
- ''
- ]
-
- expected_out_re = [
- r'\[\d/\d\] \d\.\d\ds .+',
- r'\[\d/\d\] \d\.\d\ds .+',
- r'\[\d/\d\] \d\.\d\ds .+',
- r'\[\d/\d\] \d\.\d\ds .+',
- r'\[\d/\d\] \d\.\d\ds .+',
- r'\[\d/\d\] \d\.\d\ds .+',
- ] + test_fail_output + [
- re.escape('Retrying failed tests serially.'),
- r'\[\d/\d\] \d\.\d\ds .+',
- ] + test_fail_output + [
+ '',
re.escape('Summary:'),
re.escape('Baz.Fail failed'),
re.escape('Success: 3 75.00%'),
@@ -143,7 +136,7 @@ class TraceTestCases(unittest.TestCase):
('Foo.Bar1', 1),
('Foo.Bar2', 1),
('Foo.Bar3', 1),
- ('Baz.Fail', 4)
+ ('Baz.Fail', 3)
]
self._check_results_file(expected_result_file_entries)
« no previous file with comments | « tools/isolate/run_test_cases.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698