Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: tools/isolate/run_test_cases.py

Issue 10825448: Remove Retrying Failed Tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/isolate/run_test_cases_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/run_test_cases.py
diff --git a/tools/isolate/run_test_cases.py b/tools/isolate/run_test_cases.py
index 3200c02f013c48ba3a516bf21b9c6f2951e0c479..d690baed6099a9fb69c93f04ab5c710442706c1e 100755
--- a/tools/isolate/run_test_cases.py
+++ b/tools/isolate/run_test_cases.py
@@ -587,26 +587,6 @@ def run_test_cases(executable, test_cases, jobs, timeout, result_file):
else:
assert False, items
- # Retry all the failures serially to see if they are just flaky when
- # run at the same time.
- if fail:
- print 'Retrying failed tests serially.'
- progress = Progress(len(fail))
- function = Runner(
- executable, os.getcwd(), timeout, progress, retry_count=1).map
- test_cases_retry = fail[:]
-
- for test_case in test_cases_retry:
- output = function(test_case)
- progress.print_update()
- results[output[0]['test_case']].append(output)
- if not output[0]['returncode']:
- fail.remove(test_case)
- flaky.append(test_case)
-
- LogResults(result_file, results)
- sys.stdout.write('\n')
-
print 'Summary:'
for test_case in sorted(flaky):
items = results[test_case]
« no previous file with comments | « no previous file | tools/isolate/run_test_cases_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698