Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 10825329: Rolling the DEPS of Breakpad. (Closed)

Created:
8 years, 4 months ago by Jay Civelli
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Rolling the DEPS of Breakpad. Rolling the DEPS of Breakpad in order to get the file descriptor support for generating minidumps, it is needed on Android. BUG=None TEST=Breakpad unit-tests should compile and run. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151612

Patch Set 1 #

Patch Set 2 : Minor indent fix. #

Patch Set 3 : Fixed some breadpad targets #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -220 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/breakpad.gyp View 1 2 4 chunks +6 lines, -1 line 0 comments Download
M breakpad/linux/generate-test-dump.cc View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/app/breakpad_linux.cc View 1 9 chunks +208 lines, -211 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Jay Civelli
8 years, 4 months ago (2012-08-14 05:37:23 UTC) #1
Mark Mentovai
LGTM http://codereview.chromium.org/10825329/diff/1004/chrome/app/breakpad_linux.cc File chrome/app/breakpad_linux.cc (right): http://codereview.chromium.org/10825329/diff/1004/chrome/app/breakpad_linux.cc#newcode71 chrome/app/breakpad_linux.cc:71: using google_breakpad::ExceptionHandler; I don’t think that these using-declarations ...
8 years, 4 months ago (2012-08-14 13:00:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10825329/1004
8 years, 4 months ago (2012-08-14 16:25:14 UTC) #3
commit-bot: I haz the power
Try job failure for 10825329-1004 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-14 18:26:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10825329/1004
8 years, 4 months ago (2012-08-14 19:29:06 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 00:08:05 UTC) #6
Change committed as 151612

Powered by Google App Engine
This is Rietveld 408576698