Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: breakpad/linux/generate-test-dump.cc

Issue 10825329: Rolling the DEPS of Breakpad. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed some breadpad targets Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: breakpad/linux/generate-test-dump.cc
diff --git a/breakpad/linux/generate-test-dump.cc b/breakpad/linux/generate-test-dump.cc
index f933ab48e297a9a784ce784d0ad141bca6ea7d08..b0dca00a3679a062cb398d4f1cca95867ef6279c 100644
--- a/breakpad/linux/generate-test-dump.cc
+++ b/breakpad/linux/generate-test-dump.cc
@@ -37,7 +37,7 @@
#include "breakpad/src/common/linux/linux_libc_support.h"
#include "third_party/lss/linux_syscall_support.h"
-static bool DumpCallback(const char* dump_path, const char* minidump_id,
+static bool DumpCallback(const google_breakpad::MinidumpDescriptor& descriptor,
void* context, bool success) {
if (!success) {
static const char msg[] = "Failed to write minidump\n";
@@ -47,10 +47,8 @@ static bool DumpCallback(const char* dump_path, const char* minidump_id,
static const char msg[] = "Wrote minidump: ";
sys_write(2, msg, sizeof(msg) - 1);
- sys_write(2, dump_path, my_strlen(dump_path));
- sys_write(2, "/", 1);
- sys_write(2, minidump_id, my_strlen(minidump_id));
- sys_write(2, ".dmp\n", 5);
+ sys_write(2, descriptor.path(), strlen(descriptor.path()));
+ sys_write(2, "\n", 1);
return true;
}
@@ -61,8 +59,9 @@ static void DoSomethingWhichCrashes() {
}
int main() {
- google_breakpad::ExceptionHandler breakpad(".", NULL, DumpCallback, NULL,
- true);
+ google_breakpad::MinidumpDescriptor minidump(".");
+ google_breakpad::ExceptionHandler breakpad(minidump, NULL, DumpCallback, NULL,
+ true, -1);
DoSomethingWhichCrashes();
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698