gesture: Make sure a combination of sync/async touch-events work correctly.

gesture recognizer: Make sure a combination of sync/async touch-events work correctly.

It is possible that a window starts doing synchronous touch-event handling
after doing asynchronous handling for some time. As a result, these sync
events may be processed before the acks for the queued asynchronous events
have been processed. This results in unexpected behaviour. So in such cases,
queue up the synchronous events so that they get processed only after the
asynchronous events are processed.

BUG=139339, 134486
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151361

[sadrul, 2012-08-13 18:21:54]

rjkroege@, sky@ Please review.

varunjain@ FYI

[rjkroege, 2012-08-13 20:43:53]

lgtm

am concerned (in general) about our handling of isProcessed logic. This seems
unclear to me.

http://codereview.chromium.org/10825323/diff/6001/ui/base/gestures/gesture_re...
File ui/base/gestures/gesture_recognizer_impl.cc (right):

http://codereview.chromium.org/10825323/diff/6001/ui/base/gestures/gesture_re...
ui/base/gestures/gesture_recognizer_impl.cc:270: // A touch release was was
processed (e.g. preventDefault()ed by a
per our discussion earlier about gestures not being modifiable, shouldn't this
logic be inverted in the sense that we should only ignore the touches
constructing gestures for suppressable gestures?

[sadrul, 2012-08-13 20:52:56]

http://codereview.chromium.org/10825323/diff/6001/ui/base/gestures/gesture_re...
File ui/base/gestures/gesture_recognizer_impl.cc (right):

http://codereview.chromium.org/10825323/diff/6001/ui/base/gestures/gesture_re...
ui/base/gestures/gesture_recognizer_impl.cc:270: // A touch release was was
processed (e.g. preventDefault()ed by a
On 2012/08/13 20:43:53, rjkroege wrote:
> per our discussion earlier about gestures not being modifiable, shouldn't this
> logic be inverted in the sense that we should only ignore the touches
> constructing gestures for suppressable gestures? 

This is specifically for the case that if the touch-release event gets
preventDefault()ed during a tap, then the GR cancels the tap-event, and is able
to cleanup internal state accordingly. This is essentially a workaround that we
have had for a long time that we can now cleanup using TouchStatusInternal. I
will do that in a followup CL.

[sky, 2012-08-13 21:20:49]

LGTM