Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10825316: Invalid FileSystemURL should not be given to FileUtils (Closed)

Created:
8 years, 4 months ago by kinuko
Modified:
8 years, 4 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Invalid FileSystemURL should not be given to FileUtils (In usual call path it errors out before it calls into FileUtil) BUG=none TEST=IsolatedFileUtilTest.UnregisteredPathsTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151253

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M webkit/fileapi/isolated_file_util.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M webkit/fileapi/isolated_file_util_unittest.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
A small fix-- can you take a look? Thanks!!
8 years, 4 months ago (2012-08-13 08:22:03 UTC) #1
tzik
lgtm
8 years, 4 months ago (2012-08-13 08:29:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10825316/1
8 years, 4 months ago (2012-08-13 08:39:00 UTC) #3
commit-bot: I haz the power
Failed to apply patch for webkit/fileapi/isolated_file_util.cc: While running patch -p1 --forward --force; patching file webkit/fileapi/isolated_file_util.cc ...
8 years, 4 months ago (2012-08-13 08:39:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10825316/7003
8 years, 4 months ago (2012-08-13 09:21:48 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 11:39:19 UTC) #6
Change committed as 151253

Powered by Google App Engine
This is Rietveld 408576698