Invalid FileSystemURL should not be given to FileUtils

webkit/fileapi/isolated_file_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/isolated_file_util.h"
 
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 100 matching lines @@
 
 //-------------------------------------------------------------------------
 
 IsolatedFileUtil::IsolatedFileUtil() {}
 
 PlatformFileError IsolatedFileUtil::GetLocalFilePath(
     FileSystemOperationContext* context,
     const FileSystemURL& url,
     FilePath* local_file_path) {
   DCHECK(local_file_path);
+  DCHECK(url.is_valid());
   if (url.path().empty()) {
     // Root direcory case, which should not be accessed.
     return base::PLATFORM_FILE_ERROR_ACCESS_DENIED;
   }
   *local_file_path = url.path();
   return base::PLATFORM_FILE_OK;
 }
 
 //-------------------------------------------------------------------------
 
 DraggedFileUtil::DraggedFileUtil() {}
 
 PlatformFileError DraggedFileUtil::GetFileInfo(
     FileSystemOperationContext* context,
     const FileSystemURL& url,
     PlatformFileInfo* file_info,
     FilePath* platform_path) {
   DCHECK(file_info);
   std::string filesystem_id;
+  DCHECK(url.is_valid());
   if (url.path().empty()) {
     // The root directory case.
     // For now we leave three time fields (modified/accessed/creation time)
     // NULL as it is not really clear what to be set for this virtual directory.
     // TODO(kinuko): Maybe we want to set the time when this filesystem is
     // created (i.e. when the files/directories are dropped).
     file_info->is_directory = true;
     file_info->is_symbolic_link = false;
     file_info->size = 0;
     return base::PLATFORM_FILE_OK;
   }
   base::PlatformFileError error =
       NativeFileUtil::GetFileInfo(url.path(), file_info);
   if (file_util::IsLink(url.path()) && !FilePath().IsParent(url.path())) {
     // Don't follow symlinks unless it's the one that are selected by the user.
     return base::PLATFORM_FILE_ERROR_NOT_FOUND;
   }
   if (error == base::PLATFORM_FILE_OK)
     *platform_path = url.path();
   return error;
 }
 
 FileSystemFileUtil::AbstractFileEnumerator*
 DraggedFileUtil::CreateFileEnumerator(
     FileSystemOperationContext* context,
     const FileSystemURL& root,
     bool recursive) {
+  DCHECK(root.is_valid());
   if (!root.path().empty())
     return NativeFileUtil::CreateFileEnumerator(root.path(), recursive);
 
   // Root path case.
   std::vector<FileInfo> toplevels;
   IsolatedContext::GetInstance()->GetDraggedFileInfo(
       root.filesystem_id(), &toplevels);
   if (!recursive)
     return new SetFileEnumerator(toplevels);
   return new RecursiveSetFileEnumerator(toplevels);
 }
 
 bool DraggedFileUtil::IsDirectoryEmpty(
     FileSystemOperationContext* context,
     const FileSystemURL& url) {
+  DCHECK(url.is_valid());
   if (url.path().empty()) {
     // The root directory case.
     std::vector<FileInfo> toplevels;
     bool success = IsolatedContext::GetInstance()->GetDraggedFileInfo(
         url.filesystem_id(), &toplevels);
     DCHECK(success);
     return toplevels.empty();
   }
   return NativeFileUtil::IsDirectoryEmpty(url.path());
 }
 
 }  // namespace