Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825302: mac: Remove more 10.5-only code (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, mihaip-chromium-reviews_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, jeremya+watch_chromium.org, jam, garykac+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, sanjeevr, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, alexeypa+watch_chromium.org, erikwright+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

mac: Remove more 10.5-only code BUG=137676 TBR=jamiewalch,tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151142

Patch Set 1 #

Patch Set 2 : 10.8 #

Total comments: 4

Patch Set 3 : tweak comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -133 lines) Patch
M base/mac/mac_util.h View 2 chunks +0 lines, -9 lines 0 comments Download
M base/mac/mac_util.mm View 2 chunks +1 line, -13 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 2 1 chunk +17 lines, -10 lines 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/daemon_controller_mac.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/video_frame_capturer_unittest.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M ui/base/cocoa/underlay_opengl_hosting_window.mm View 1 2 1 chunk +33 lines, -37 lines 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nico
As requested.
8 years, 4 months ago (2012-08-10 20:22:23 UTC) #1
Mark Mentovai
LGTM.
8 years, 4 months ago (2012-08-10 20:27:22 UTC) #2
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/10825302/diff/8001/ui/base/cocoa/underlay_opengl_hosting_window.mm File ui/base/cocoa/underlay_opengl_hosting_window.mm (right): https://chromiumcodereview.appspot.com/10825302/diff/8001/ui/base/cocoa/underlay_opengl_hosting_window.mm#newcode109 ui/base/cocoa/underlay_opengl_hosting_window.mm:109: // titled if we want hole punching to work. ...
8 years, 4 months ago (2012-08-10 20:29:06 UTC) #3
Nico
https://chromiumcodereview.appspot.com/10825302/diff/8001/ui/base/cocoa/underlay_opengl_hosting_window.mm File ui/base/cocoa/underlay_opengl_hosting_window.mm (right): https://chromiumcodereview.appspot.com/10825302/diff/8001/ui/base/cocoa/underlay_opengl_hosting_window.mm#newcode109 ui/base/cocoa/underlay_opengl_hosting_window.mm:109: // titled if we want hole punching to work. ...
8 years, 4 months ago (2012-08-10 20:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10825302/11001
8 years, 4 months ago (2012-08-10 20:41:14 UTC) #5
commit-bot: I haz the power
Presubmit check for 10825302-11001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-10 20:41:21 UTC) #6
Nico
OWNERS: avi:content thestig:printing tony:webkit jamiewalch:remoting
8 years, 4 months ago (2012-08-10 20:47:04 UTC) #7
Avi (use Gerrit)
lgtm
8 years, 4 months ago (2012-08-10 20:58:55 UTC) #8
Lei Zhang
Printing lgtm
8 years, 4 months ago (2012-08-10 21:33:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10825302/11001
8 years, 4 months ago (2012-08-10 21:36:10 UTC) #10
commit-bot: I haz the power
Change committed as 151142
8 years, 4 months ago (2012-08-10 22:47:18 UTC) #11
Jamie
8 years, 4 months ago (2012-08-11 05:04:37 UTC) #12 
remoting lgtm (FWIW)

Powered by Google App Engine
This is Rietveld 408576698