mac: Remove more 10.5-only code

ui/base/cocoa/underlay_opengl_hosting_window.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/base/cocoa/underlay_opengl_hosting_window.h"
 
 #import <objc/runtime.h>
 
 #include "base/logging.h"
 #include "base/mac/mac_util.h"
@@ skipping 86 matching lines @@
   // not do this. Use kWindowSizeDeterminedLater in
   // ui/base/cocoa/window_size_constants.h instead.
   //
   // (This is checked here because UnderlayOpenGLHostingWindow is the base of
   // most Chromium windows, not because this is related to its functionality.)
   DCHECK(!NSIsEmptyRect(contentRect));
   if ((self = [super initWithContentRect:contentRect
                                styleMask:windowStyle
                                  backing:bufferingType
                                    defer:deferCreation])) {
-    if (base::mac::IsOSSnowLeopardOrLater()) {
-      // Hole punching is used when IOSurfaces are used to transport, which is
-      // only on > 10.5. Therefore, on > 10.5, the window must always be
-      // non-opaque whether or not it's titled if we want hole punching to work.
-      [self setOpaque:NO];
+    // Hole punching is used when IOSurfaces are used to transport.
+    // Therefore  the window must always be non-opaque whether or not it's
+    // titled if we want hole punching to work.

[Avi (use Gerrit), 2012/08/10 20:29:07]

This comment is now a little awkward. Try:

OpenGL-accelerated content works by punching holes in windows. Therefore all
windows hosting OpenGL content must not be opaque.

[Nico, 2012/08/10 20:40:12]

Done.

+    [self setOpaque:NO];
 
-      if (windowStyle & NSTitledWindowMask) {
-        // Only fiddle with shadows if the window is a proper window with a
-        // title bar and all. (The invisible opaque area technique only works on
-        // > 10.5, but that is guaranteed by this point.)
-        [self _setContentHasShadow:NO];
+    if (windowStyle & NSTitledWindowMask) {
+      // Only fiddle with shadows if the window is a proper window with a
+      // title bar and all. (The invisible opaque area technique only works on
+      // > 10.5, but that is guaranteed by this point.)

[Avi (use Gerrit), 2012/08/10 20:29:07]

Remove the parenthesized sentence; it is obsolete too.

[Nico, 2012/08/10 20:40:12]

Done.

+      [self _setContentHasShadow:NO];
 
-        NSView* rootView = [[self contentView] superview];
-        const NSRect rootBounds = [rootView bounds];
+      NSView* rootView = [[self contentView] superview];
+      const NSRect rootBounds = [rootView bounds];
 
-        // On 10.7/8, the bottom corners of the window are rounded by magic at a
-        // deeper level than the NSThemeFrame, so it is OK to have the opaques
-        // go all the way to the bottom.
-        const CGFloat kTopEdgeInset = 16;
-        const CGFloat kAlphaValueJustOpaqueEnough = 0.002;
+      // On 10.7/8, the bottom corners of the window are rounded by magic at a
+      // deeper level than the NSThemeFrame, so it is OK to have the opaques
+      // go all the way to the bottom.
+      const CGFloat kTopEdgeInset = 16;
+      const CGFloat kAlphaValueJustOpaqueEnough = 0.002;
 
-        scoped_nsobject<NSView> leftOpaque([[OpaqueView alloc] initWithFrame:
-            NSMakeRect(NSMinX(rootBounds), NSMinY(rootBounds),
-                       1, NSHeight(rootBounds) - kTopEdgeInset)]);
-        [leftOpaque setAutoresizingMask:NSViewMaxXMargin |
-                                        NSViewHeightSizable];
-        [leftOpaque setAlphaValue:kAlphaValueJustOpaqueEnough];
-        [rootView addSubview:leftOpaque];
+      scoped_nsobject<NSView> leftOpaque([[OpaqueView alloc] initWithFrame:
+          NSMakeRect(NSMinX(rootBounds), NSMinY(rootBounds),
+                     1, NSHeight(rootBounds) - kTopEdgeInset)]);
+      [leftOpaque setAutoresizingMask:NSViewMaxXMargin |
+                                      NSViewHeightSizable];
+      [leftOpaque setAlphaValue:kAlphaValueJustOpaqueEnough];
+      [rootView addSubview:leftOpaque];
 
-        scoped_nsobject<NSView> rightOpaque([[OpaqueView alloc] initWithFrame:
-            NSMakeRect(NSMaxX(rootBounds) - 1, NSMinY(rootBounds),
-                       1, NSHeight(rootBounds) - kTopEdgeInset)]);
-        [rightOpaque setAutoresizingMask:NSViewMinXMargin |
-                                         NSViewHeightSizable];
-        [rightOpaque setAlphaValue:kAlphaValueJustOpaqueEnough];
-        [rootView addSubview:rightOpaque];
-      }
+      scoped_nsobject<NSView> rightOpaque([[OpaqueView alloc] initWithFrame:
+          NSMakeRect(NSMaxX(rootBounds) - 1, NSMinY(rootBounds),
+                     1, NSHeight(rootBounds) - kTopEdgeInset)]);
+      [rightOpaque setAutoresizingMask:NSViewMinXMargin |
+                                       NSViewHeightSizable];
+      [rightOpaque setAlphaValue:kAlphaValueJustOpaqueEnough];
+      [rootView addSubview:rightOpaque];
     }
   }
 
   return self;
 }
 
 @end