Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825254: Remove views::KeyEvent, replacing uses of it with ui::KeyEvent. (Closed)

Created:
8 years, 4 months ago by Ben Goodger (Google)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, asanka, mihaip-chromium-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Remove views::KeyEvent, replacing uses of it with ui::KeyEvent. http://crbug.com/125937 TEST=existing TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150895

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -402 lines) Patch
M ash/system/tray/tray_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/app_menu_button_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_menu_button_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_action_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_aura.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_aura.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/chrome_to_mobile_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_container.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/shell/shell_aura.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/app_list/app_list_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/app_list/apps_grid_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/apps_grid_view.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/app_list/contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/contents_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/app_list/search_box_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_box_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/app_list/search_result_list_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_result_list_view.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 4 chunks +19 lines, -7 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/combobox.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_wrapper.h View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/views/controls/link.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/link.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/menu/submenu_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/scroll_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scroll_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/slider.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/table/table_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_views.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 5 chunks +5 lines, -6 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/tree/tree_view_views.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/tree/tree_view_views.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/events/event.h View 1 chunk +0 lines, -44 lines 0 comments Download
M ui/views/events/event.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/views/events/event_aura.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/views/events/event_unittest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
D ui/views/events/event_win.cc View 1 2 3 4 5 1 chunk +0 lines, -18 lines 0 comments Download
M ui/views/events/event_x.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M ui/views/examples/textfield_example.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/textfield_example.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/focus/accelerator_handler_win.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/focus/focus_manager.h View 4 chunks +4 lines, -3 lines 0 comments Download
M ui/views/focus/focus_manager.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ui/views/focus/focus_manager_unittest_win.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/ime/input_method.h View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/views/ime/input_method_base.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/ime/input_method_base.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/ime/input_method_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/ime/input_method_bridge.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/ime/input_method_delegate.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/views/ime/input_method_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/ime/input_method_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/ime/mock_input_method.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/ime/mock_input_method.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/view.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/view_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 4 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
8 years, 4 months ago (2012-08-08 21:05:16 UTC) #1
sky
LGTM http://codereview.chromium.org/10825254/diff/9014/chrome/browser/ui/views/dropdown_bar_host_aura.cc File chrome/browser/ui/views/dropdown_bar_host_aura.cc (right): http://codereview.chromium.org/10825254/diff/9014/chrome/browser/ui/views/dropdown_bar_host_aura.cc#newcode18 chrome/browser/ui/views/dropdown_bar_host_aura.cc:18: ui::Event* ui_event = Seems like NativeWebKeyboardEvent should take ...
8 years, 4 months ago (2012-08-08 21:39:18 UTC) #2
Ben Goodger (Google)
+jochen for content/shell change
8 years, 4 months ago (2012-08-09 20:57:20 UTC) #3
jochen (gone - plz use gerrit)
8 years, 4 months ago (2012-08-09 20:59:34 UTC) #4 
content/shell lgtm

Powered by Google App Engine
This is Rietveld 408576698