Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10825199: There are two places that log failure to start, tweak the message to tell (Closed)

Created:
8 years, 4 months ago by TVL
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

There are two places that log failure to start, tweak the message to tell which one it was in logs.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/iossim/iossim.mm View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
TVL
8 years, 4 months ago (2012-08-06 15:08:44 UTC) #1
lliabraa
lgtm
8 years, 4 months ago (2012-08-06 15:12:57 UTC) #2
TVL
+rohit so either he or Stuart can give it the Owners' LG
8 years, 4 months ago (2012-08-06 15:33:54 UTC) #3
rohitrao (ping after 24h)
LGTM Tom, should we make you an OWNER of this code? https://chromiumcodereview.appspot.com/10825199/diff/1/testing/iossim/iossim.mm File testing/iossim/iossim.mm (right): ...
8 years, 4 months ago (2012-08-06 16:21:55 UTC) #4
TVL
https://chromiumcodereview.appspot.com/10825199/diff/1/testing/iossim/iossim.mm File testing/iossim/iossim.mm (right): https://chromiumcodereview.appspot.com/10825199/diff/1/testing/iossim/iossim.mm#newcode671 testing/iossim/iossim.mm:671: LogError(@"Simulator failed request to start: \"%@\" (%@:%ld)", On 2012/08/06 ...
8 years, 4 months ago (2012-08-06 16:23:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thomasvl@chromium.org/10825199/1
8 years, 4 months ago (2012-08-06 16:23:41 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 17:43:21 UTC) #7
Change committed as 150107

Powered by Google App Engine
This is Rietveld 408576698