Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: testing/iossim/iossim.mm

Issue 10825199: There are two places that log failure to start, tweak the message to tell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Foundation/Foundation.h> 5 #import <Foundation/Foundation.h>
6 #include <asl.h> 6 #include <asl.h>
7 #include <libgen.h> 7 #include <libgen.h>
8 #include <stdarg.h> 8 #include <stdarg.h>
9 #include <stdio.h> 9 #include <stdio.h>
10 10
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 NSError* error; 661 NSError* error;
662 BOOL started = [session requestStartWithConfig:config 662 BOOL started = [session requestStartWithConfig:config
663 timeout:kSessionStartTimeoutSeconds 663 timeout:kSessionStartTimeoutSeconds
664 error:&error]; 664 error:&error];
665 665
666 // Spin the runtime indefinitely. When the delegate gets the message that the 666 // Spin the runtime indefinitely. When the delegate gets the message that the
667 // app has quit it will exit this program. 667 // app has quit it will exit this program.
668 if (started) { 668 if (started) {
669 [[NSRunLoop mainRunLoop] run]; 669 [[NSRunLoop mainRunLoop] run];
670 } else { 670 } else {
671 LogError(@"Simulator failed to start: \"%@\" (%@:%ld)", 671 LogError(@"Simulator failed request to start: \"%@\" (%@:%ld)",
rohitrao (ping after 24h) 2012/08/06 16:21:55 I don't understand what this new error message mea
TVL 2012/08/06 16:23:27 The other case also just had "Simulator failed to
672 [error localizedDescription], 672 [error localizedDescription],
673 [error domain], static_cast<long int>([error code])); 673 [error domain], static_cast<long int>([error code]));
674 } 674 }
675 675
676 // Note that this code is only executed if the simulator fails to start 676 // Note that this code is only executed if the simulator fails to start
677 // because once the main run loop is started, only the delegate calling 677 // because once the main run loop is started, only the delegate calling
678 // exit() will end the program. 678 // exit() will end the program.
679 [pool drain]; 679 [pool drain];
680 return EXIT_FAILURE; 680 return EXIT_FAILURE;
681 } 681 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698