src/api.cc - Issue 10825196: Allow SetHiddenValue to accept empty value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 10825196: Allow SetHiddenValue to accept empty value. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 77bb9828253f327808d88b8200c236ed4e467de7..954f82144135a95cf2832a5cf90c135c7ab96135 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3299,6 +3299,7 @@ bool v8::Object::SetHiddenValue(v8::Handle<v8::String> key,

v8::Handle<v8::Value> value) {

i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();

ON_BAILOUT(isolate, "v8::Object::SetHiddenValue()", return false);

+ if (value.IsEmpty()) return DeleteHiddenValue(key);

ENTER_V8(isolate);

i::HandleScope scope(isolate);

i::Handle<i::JSObject> self = Utils::OpenHandle(this);

« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »